From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 2DAC91396 for ; Fri, 15 Sep 2017 15:34:32 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7F62D20BF6; Fri, 15 Sep 2017 09:34:31 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 15 Sep 2017 09:34:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=ezox6A6xwV2RERm k5wvwat3cZzrVonl4joxBEXwGBBc=; b=hhBn/i1Tmjvr74imD+YCVcwYkgceBck CtqJ98tsQJnUXTPhHmONB3jITYgWipv4HwjvIo0KXp84ajusj6Yr91S3hBS/5Aui EmL5LMkZvmX3lr6mt0POurpWj0Lm6liAbS73VdIhgsr56CVDUdmHusRuWrAEW4/R bYMg9vtBU8ZA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=ezox6A6xwV2RERmk5wvwat3cZzrVonl4joxBEXwGBBc=; b=KRns5g/W VM+q9Xsapjx0Zetv+sqxkOYAK9MX+rq7aHIpc0Fy9/DIErt79nnBDUSB0ebyGW1W olEbAXLWu313uLupwscmXsmEfX8hoTyzjoBvWK0XESCcCDIQfY6q3nBBCNpxVC/4 QWiZytSG5jJ2BfkRfCxaW/ul1LB+6fE4cnm9P/PdgfZqDhVvttY8oFSEhk6KOpoC EethjrdJ8EwXRkQaDREnckJ4lqFeuFfGInz/9QbwWbsq9mped22qeyp/Al3piXis 48b1nwPY1Vw01fhJO5Ii//ZNhbLM25oNiuoP50uJT+QdsrWXfnOKjPWlXmK11lTU X97VI9lBqWzDCw== X-ME-Sender: X-Sasl-enc: LxMCbdpazusceEIGf7D8CVZ5DnTnctThXLM9BwfPgbgF 1505482471 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2D272240A4; Fri, 15 Sep 2017 09:34:31 -0400 (EDT) From: Thomas Monjalon To: Guduri Prathyusha Cc: dev@dpdk.org, "Van Haaren, Harry" Date: Fri, 15 Sep 2017 15:34:30 +0200 Message-ID: <48564633.AYoj5gbtiS@xps> In-Reply-To: References: <20170906071541.1922-1-gprathyusha@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] service: fix service lcore stop function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Sep 2017 13:34:32 -0000 > > lcore_states store the state of the lcore. Fixing the invalid > > dereference of lcore_states with service number > > > > Unit test case service_lcore_start_stop fails with the above fix. > > Service core was stopped without stopping the service. > > > > This commit fixes the test by adding negative and positive cases of > > stopping the service lcore before and after stopping the service > > respectively > > > > Fixes: 21698354c832 ("service: introduce service cores concept") > > Fixes: f038a81e1c56 ("service: add unit tests") > > > > Signed-off-by: Guduri Prathyusha > > Thanks for fixing and rebase / update to v2. Please mark the v1 of this patchset as "Superseded" in patchwork. > > Reviewed-by: Harry van Haaren Applied, thanks