From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 37C4C1BB26 for ; Fri, 27 Oct 2017 01:14:17 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BD3E82073F; Thu, 26 Oct 2017 19:14:16 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 26 Oct 2017 19:14:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=UTRwGaCjPzJyZru8iDUu+Wnlh7 Eh0YsVokuKdPmCZgY=; b=B36zlJUGhZXvraA3vENzLuGFEBnMoCAMedBo1FrkMW 4gTbLfTvhnVLGPnnns7QLVwhTiFnmYUQLRjws1CQBRvN2QD00FRvAG1YoT+azhjq wNycukpz8HPFfBx2aAk213UX7GQMTPw0W3kPc7r1/Ng6woi7G6j7RR8YMz4MolCL 8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=UTRwGa CjPzJyZru8iDUu+Wnlh7Eh0YsVokuKdPmCZgY=; b=c2KYTGOhhIbhTyD1MxOgv6 xlABdSRnhfWQLjpJjkiFpfR0nED9b21gaV7i8iJaumQK0pVs4Y83qexYdRQOPuKq jIQAMOEUGQ1udIsUsD2+w6+rc/afiWpjmr0L1g7NLQUpZjI023L/b/uklIbKZn4k 2lAHuvmiVBBKk1ViHtoGj4QD2692F49kyL2gQY0nUc74m7HXWn3a1j0GZ1baUtRp wugdT10jdS5R39lrZTW3m8VR60FCV6dHRXEanOCQU4pMRHD6l5PUwwiaNrYQ+tJG XXKKwA5ZbAy9rFilmIa3hv7DrdNA4psZhkr1e287poiENaULFLnW4Ou24DXSIdYA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 671AE7E13B; Thu, 26 Oct 2017 19:14:16 -0400 (EDT) From: Thomas Monjalon To: Ori Kam Cc: dev@dpdk.org, adrien.mazarguil@6wind.com, john.mcnamara@intel.com Date: Fri, 27 Oct 2017 01:14:15 +0200 Message-ID: <4865583.3QcsuuSVpe@xps> In-Reply-To: <28eeef90ebaf5e8afb31837fade1b36c484f29a5.1508953769.git.orika@mellanox.com> References: <1508407471-6252-1-git-send-email-orika@mellanox.com> <28eeef90ebaf5e8afb31837fade1b36c484f29a5.1508953769.git.orika@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] examples/flow_filtering: demo of simple rte flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2017 23:14:17 -0000 Few comments below, Ori: 25/10/2017 19:58, Ori Kam: > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -978,3 +978,7 @@ F: examples/tep_termination/ > F: examples/vmdq/ > F: examples/vmdq_dcb/ > F: doc/guides/sample_app_ug/vmdq_dcb_forwarding.rst > + > +M: Ori Kam > +F: examples/flow_filtering/ > +F: doc/guides/sample_app_ug/flow_filtering.rst Please keep examples in alphabetical order. > --- a/doc/guides/sample_app_ug/index.rst > +++ b/doc/guides/sample_app_ug/index.rst > @@ -77,6 +77,7 @@ Sample Applications User Guides > ptpclient > performance_thread > ipsec_secgw > + flow_filtering I don't know whether there is an order in this index. > --- a/examples/Makefile > +++ b/examples/Makefile > @@ -100,5 +100,6 @@ endif > endif > > DIRS-y += eventdev_pipeline_sw_pmd > +DIRS-y += flow_filtering Most of apps are in alphabetical order in this Makefile. > --- /dev/null > +++ b/examples/flow_filtering/Makefile > @@ -0,0 +1,17 @@ A license header is required. > +ifeq ($(RTE_SDK),) > +$(error "Please define RTE_SDK environment variable") > +endif > + > +# Default target, can be overridden by command line or environment > +RTE_TARGET ?= x86_64-native-linuxapp-gcc > + > +include $(RTE_SDK)/mk/rte.vars.mk > + > +APP = flow > + > +SRCS-y := main.c > + > +CFLAGS += -g3 -g3 ? Is it a mistake? > --- /dev/null > +++ b/examples/flow_filtering/main.c > @@ -0,0 +1,244 @@ > +/*- > + * BSD LICENSE > + * > + * Copyright 2017 Mellanox. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > + * > + * * Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * * Redistributions in binary form must reproduce the above copyright > + * notice, this list of conditions and the following disclaimer in > + * the documentation and/or other materials provided with the > + * distribution. > + * * Neither the name of 6WIND S.A. nor the names of its Wrong copyright holder reference here.