From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 8701C25D9 for ; Thu, 26 Jul 2018 16:14:39 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E6A1C2200A; Thu, 26 Jul 2018 10:14:38 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 26 Jul 2018 10:14:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=oNxrkSRcrKko9uUAgO6ySohA0h SCWhikp63uTOF6mNE=; b=TJ5OaTpbkeu6JMWbCLU9NsrQ7i3aYbnefKsKu7L/WI 5emDM5SMinNULbjznmzmyrv8YGdfbx7R3jbXyqn0IklL2D4D/5WhJtAsHOpHzk+s 3Jgi5U4YKVbv2K8qeH/OA5/4Fdb/XSyD8BfE1UsgycLjvRX8+/9BCUuq1be0N/LT M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=oNxrkS RcrKko9uUAgO6ySohA0hSCWhikp63uTOF6mNE=; b=N5rVOGkO04a+kFx5dzRkQI N+O8fTsjfBmv2Np5ti62SMg8z1n939NH5Yj84/3XGa/yyRPIvxqsDvAVZDxZemLb UvXhEkM6jMw8r4AtL4jkVVuBkflWESDwNamSVtmS/AWc4TV6jVQi8pxXJ2cW83xW NpVE4Ih4rGgD+QCoxWA2NTOVU8SgEMdDoZqVQ2ho2unM1aF3XOqPaUX0Gh7leKBI bglFgtQIHloRnPt/ZEdWR6ffbILRE78135g5Fn5Pur/9aNsWW257ZC+2rovOAiii XZpwK5bqVbAd0Rm1xG7/aUYURHhmoAQmpd5ZS5Hql0UpTUieQUm3+yKDWwW1bHRQ == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8AF631026C; Thu, 26 Jul 2018 10:14:37 -0400 (EDT) From: Thomas Monjalon To: "Pattan, Reshma" Cc: dev@dpdk.org, "Iremonger, Bernard" , "Singh, Jasvinder" , "olivier.matz@6wind.com" , Mordechay Haimovsky , cristian.dumitrescu@intel.com Date: Thu, 26 Jul 2018 16:14:33 +0200 Message-ID: <4866271.duVD2LWeSr@xps> In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A37617A@IRSMSX109.ger.corp.intel.com> References: <20180723104425.10090-1-jasvinder.singh@intel.com> <1532441847-7492-1-git-send-email-reshma.pattan@intel.com> <3AEA2BF9852C6F48A459DA490692831F2A37617A@IRSMSX109.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix testpmd exit for ctrl+d X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jul 2018 14:14:39 -0000 24/07/2018 16:46, Pattan, Reshma: > + CC: Olivier and Mordechay Haimovsky. > > > Testpmd should be existed gracefully when ctrl+d is typed. > > This behaviour is not handled properly, fix this by calling > > pmd_test_exit() instead of rte_panic. > > > > Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode") > > > > Reported-by: Mordechay Haimovsky > > Signed-off-by: Jasvinder Singh > > Signed-off-by: Reshma Pattan > > --- > > v2: removed changes done to lib/librte_cmdline/cmdline.c reworded commit > > message and heading. The partial revert from Moti is preferred.