From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id D04A91B60C
 for <dev@dpdk.org>; Mon, 16 Oct 2017 12:41:21 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 43E4F204B0;
 Mon, 16 Oct 2017 06:41:21 -0400 (EDT)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Mon, 16 Oct 2017 06:41:21 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=JlyizrQrTQgFk0S13MRfjcb0CN
 UDvJ5dE0TB+w3ERqw=; b=jd2ZacssGcFojZXJxjvHM/oZyrYSOvpEz1VQroc812
 1RpEqbFKcVoLDxxn58fJexT+xQroJZUrLX8/zH0qFnwByezCvejFIs3tf1W8k2rr
 ZuR9IEf7E1MhWD2Wy2jDizMqkVA2gfn8jCmGMDu0/5eARfpbzCc+9UcPtCdRc1kl
 I=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Jlyizr
 QrTQgFk0S13MRfjcb0CNUDvJ5dE0TB+w3ERqw=; b=LE1+hN+Zwrz4LiPxPFbcwB
 xozhQN/yJHbXzQZeKpoDeH6w49rGrfszTvV4rPB7TXfTM7JPMf79v8kKValKf7d/
 S3eyleO/p1k9l5gZ3JVmjTRcqPZI9ViBUii0u7yVyZU9pYHXvDP/WIoa0elbejnI
 6sQ6tcYVMdGRmv/hZ4jSOVjpIVPkGijYzc5z8rgq0SmMrnF0XIoXlHcMf34EIdKz
 alUPguz+DR7VFtKjI0GvcNGfT5MEyae/rVQoBF8+d/kPrqDhHMAl6AJ7ortg6p3e
 G5qZCvQKCW8M2MY3wamur4AgfPK73r/3zS6CB6Zh+URa62HQGj0GU/QKaThD8eug
 ==
X-ME-Sender: <xms:0YzkWSrVrNVIeViOoMY90RrbF3w98NHQek_Gd_kAmN6bGxbg4z0iHA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id DFE27248B1;
 Mon, 16 Oct 2017 06:41:20 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Aviad Yehezkel <aviadye@dev.mellanox.co.il>
Cc: Akhil Goyal <akhil.goyal@nxp.com>, dev@dpdk.org, declan.doherty@intel.com,
 pablo.de.lara.guarch@intel.com, hemant.agrawal@nxp.com, radu.nicolau@intel.com,
 borisp@mellanox.com, aviadye@mellanox.com, sandeep.malik@nxp.com,
 jerin.jacob@caviumnetworks.com, john.mcnamara@intel.com,
 konstantin.ananyev@intel.com, shahafs@mellanox.com, olivier.matz@6wind.com
Date: Mon, 16 Oct 2017 12:41:20 +0200
Message-ID: <4871517.nFyjTu3XI0@xps>
In-Reply-To: <032f2eb3-513b-bb30-a836-57a9016df940@dev.mellanox.co.il>
References: <20171006181151.4758-1-akhil.goyal@nxp.com>
 <20171014221734.15511-11-akhil.goyal@nxp.com>
 <032f2eb3-513b-bb30-a836-57a9016df940@dev.mellanox.co.il>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Oct 2017 10:41:22 -0000

15/10/2017 14:51, Aviad Yehezkel:
> 
> On 10/15/2017 1:17 AM, Akhil Goyal wrote:
> > From: Radu Nicolau <radu.nicolau@intel.com>
> >
> > Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> > Signed-off-by: Declan Doherty <declan.doherty@intel.com>
> > ---
> >   drivers/net/Makefile                   |   2 +-
> >   drivers/net/ixgbe/Makefile             |   2 +-
> >   drivers/net/ixgbe/base/ixgbe_osdep.h   |   8 +
> >   drivers/net/ixgbe/ixgbe_ethdev.c       |  19 +
> >   drivers/net/ixgbe/ixgbe_ethdev.h       |   6 +-
> >   drivers/net/ixgbe/ixgbe_flow.c         |  47 +++
> >   drivers/net/ixgbe/ixgbe_ipsec.c        | 744 +++++++++++++++++++++++++++++++++
> >   drivers/net/ixgbe/ixgbe_ipsec.h        | 147 +++++++
> >   drivers/net/ixgbe/ixgbe_rxtx.c         |  53 ++-
> >   drivers/net/ixgbe/ixgbe_rxtx.h         |  11 +-
> >   drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c |  50 ++-
> >   11 files changed, 1079 insertions(+), 10 deletions(-)
> >   create mode 100644 drivers/net/ixgbe/ixgbe_ipsec.c
> >   create mode 100644 drivers/net/ixgbe/ixgbe_ipsec.h
> >
[all code lines cut]

Please Aviad, remove the useless lines when replying.
It is really annoying to scroll the whole patch to find where you replied.

> Tested-by: Aviad Yehezkel <aviadye@mellanox.com>

Really? You have tested the ixgbe driver?

When providing a test acknowledgement, it is more valuable to provide
a brief test report:
	- which hardware
	- which use case
	- results