From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f178.google.com (mail-wj0-f178.google.com [209.85.210.178]) by dpdk.org (Postfix) with ESMTP id B36362BB0 for ; Wed, 23 Nov 2016 20:18:13 +0100 (CET) Received: by mail-wj0-f178.google.com with SMTP id v7so15567668wjy.2 for ; Wed, 23 Nov 2016 11:18:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=urx3xnIGMsNX7TMnyv6+rUm7nBIWydGKM3fq9Tprt1g=; b=uReoO25NV1k6fKVmnlBFgHSZnMw/EyOg7gnOykn0vyaUtGMdfL20uOSHtQFjXObXsx Swoh3aDKj6TG49zrQdIZ8VM+sphfAiVY1oNj3t4MFfC5rKcyOleTmQP7ZPn5Z1XkXKZK UOrQzwSEGynyYxEqBmyIiKw3B4YVSJNGiTz7QFay2FMPnx9a5tpmtwOekFIqpWoyQpEK iTq8PqyvGXBpiHc1K8/sNe/WJQYkVZwwe5BTJ+WZdQC8BrCHJEbXk6byXAkHzmNHtM2Z RmMx6MpVvt0ZJxwFg7O8aaULNLf7GocL24PvyuTRt2Xk0sND3DBIAWIlwH6oJxL75ger IBWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=urx3xnIGMsNX7TMnyv6+rUm7nBIWydGKM3fq9Tprt1g=; b=KVCiiOdT+PZLUfC5ZdwCCNSIxIiV4R5dCZeVdOAqYX2ZEJ7Uq/buwzVMXD21oPapy7 dfNQATXfXy6TtXdLuDJ5eo5wNk2ExuX6QKjpd1nlSg5HxOCuzTSKxCGdOJ6lArauXmZ8 NxAQoRlLR6jpXrZTR2pcFeFZjTRt5CjnIQGSxHepWBRrl7ssMKPe5yWXrH78uaaeiN27 Wbm+uWuJBqEfrKGIOrlsztZaEmNYliR4QDKKwiirBAlBYfXCTr9NQlwcL0Dw74XX7Q1L 30vfGR/cBS/TMkSegqn7BP7Lh8u5x44v4hyNTvFbaeEpyZ0wzcSGSN8xqunqpoYPA0Y2 ZvGQ== X-Gm-Message-State: AKaTC00CJvDRZ5e14Q+x/thctldtBOLYYcqqUXnIYbvXAnIHI1RDJVewEstmJJX87HeLB/39 X-Received: by 10.194.222.202 with SMTP id qo10mr4549947wjc.115.1479928693353; Wed, 23 Nov 2016 11:18:13 -0800 (PST) Received: from xps13.localnet (112.204.154.77.rev.sfr.net. [77.154.204.112]) by smtp.gmail.com with ESMTPSA id c187sm4268732wmd.13.2016.11.23.11.18.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Nov 2016 11:18:12 -0800 (PST) From: Thomas Monjalon To: Jerin Jacob Cc: dev@dpdk.org, bruce.richardson@intel.com, harry.van.haaren@intel.com, hemant.agrawal@nxp.com, gage.eads@intel.com Date: Wed, 23 Nov 2016 20:18:09 +0100 Message-ID: <4871697.UraAQdum7A@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1479447902-3700-3-git-send-email-jerin.jacob@caviumnetworks.com> References: <1479447902-3700-1-git-send-email-jerin.jacob@caviumnetworks.com> <1479447902-3700-3-git-send-email-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/4] eventdev: implement the northbound APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Nov 2016 19:18:13 -0000 2016-11-18 11:15, Jerin Jacob: > This patch set defines the southbound driver interface > and implements the common code required for northbound > eventdev API interface. Please make two separate patches. > +#ifdef RTE_LIBRTE_EVENTDEV_DEBUG > +#define RTE_PMD_DEBUG_TRACE(...) \ > + rte_pmd_debug_trace(__func__, __VA_ARGS__) > +#else > +#define RTE_PMD_DEBUG_TRACE(...) > +#endif I would like to discuss the need for a debug option as there is already a log level. > +/* Logging Macros */ > +#define EDEV_LOG_ERR(fmt, args...) \ Every symbols and macros in an exported header must be prefixed by RTE_. > +/* Macros to check for valid device */ > +#define RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, retval) do { \ Sometimes you use RTE_EVENT_DEV_ and sometimes RTE_EVENTDEV. (I prefer the latter). > +struct rte_eventdev_driver { > + struct rte_pci_driver pci_drv; /**< The PMD is also a PCI driver. */ It must not be directly linked to the underlying bus.