From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id DF03458EE for ; Mon, 3 Nov 2014 23:08:07 +0100 (CET) Received: by mail-wi0-f182.google.com with SMTP id d1so7743233wiv.3 for ; Mon, 03 Nov 2014 14:17:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=F9Hudg05ulboB+ghU29nXwIETnIN4fDudsvnUh0PMqs=; b=DHHzzNqG7CY11ydWL5kEGCV3mpCAH+u7rZIysQFKsAvgn6iGxsl9neqxiSZuro1PT5 3eXPl19y/uqQDW1rF74xUSitwh4mJGaM+7CQQdIDhrgSlMxQgVz/7U327EiCrbu9ejeG pQ+uV7iZ7LUUni9GZW4ZTwmThNxAsAstriE6/NEVPKLTg47zd0YCwyegJHL9jUoGyOB2 QsujkmbL5Z3AWmMQMLmtb9fYs9aqxWwQ/diTeDn/ZXvkc5WFCgzg8Mqu0dS7tV6TmxO7 +dB0qyCVm4rX5GrOb3YFKjJIUjB9BlQXpEIE2eFWPgHYYe4ce3Ght+4iA2R9xoio/37b JrQg== X-Gm-Message-State: ALoCoQknhHRYhoTr39hdpF5taHFW1JU2q/pm0MKM3z3tsnByb2n+VC+P6QomjRck6b1Lvs6UR9Co X-Received: by 10.194.80.100 with SMTP id q4mr51436388wjx.15.1415053042514; Mon, 03 Nov 2014 14:17:22 -0800 (PST) Received: from xps13.localnet (guy78-1-82-235-116-147.fbx.proxad.net. [82.235.116.147]) by mx.google.com with ESMTPSA id el4sm10172918wid.11.2014.11.03.14.17.21 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Nov 2014 14:17:21 -0800 (PST) From: Thomas Monjalon To: "Chen Jing D(Mark)" Date: Mon, 03 Nov 2014 23:17:03 +0100 Message-ID: <48821528.yaSnYYWibr@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.1-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: <1413454046-13407-2-git-send-email-jing.d.chen@intel.com> References: <1411478047-1251-2-git-send-email-jing.d.chen@intel.com> <1413454046-13407-1-git-send-email-jing.d.chen@intel.com> <1413454046-13407-2-git-send-email-jing.d.chen@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/6] ether: enhancement for VMDQ support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Nov 2014 22:08:08 -0000 2014-10-16 18:07, Chen Jing D: > /** > + * Simple flags to indicate RX mq mode, which can be used independently or combined > + * in enum rte_eth_rx_mq_mode definition. > + */ > +#define ETH_MQ_RX_RSS_FLAG 0x1 > +#define ETH_MQ_RX_DCB_FLAG 0x2 > +#define ETH_MQ_RX_VMDQ_FLAG 0x4 The comment would be more useful by explaining that these flags are used for rte_eth_conf.rxmode.mq_mode. > + /**< None of DCB,RSS or VMDQ mode */ > + ETH_MQ_RX_NONE = 0, > + > + /**< For RX side, only RSS is on */ > + ETH_MQ_RX_RSS = ETH_MQ_RX_RSS_FLAG, > + /**< For RX side,only DCB is on. */ > + ETH_MQ_RX_DCB = ETH_MQ_RX_DCB_FLAG, > + /**< Both DCB and RSS enable */ > + ETH_MQ_RX_DCB_RSS = ETH_MQ_RX_RSS_FLAG | ETH_MQ_RX_DCB_FLAG, > + > + /**< Only VMDQ, no RSS nor DCB */ > + ETH_MQ_RX_VMDQ_ONLY = ETH_MQ_RX_VMDQ_FLAG, > + /**< RSS mode with VMDQ */ > + ETH_MQ_RX_VMDQ_RSS = ETH_MQ_RX_RSS_FLAG | ETH_MQ_RX_VMDQ_FLAG, > + /**< Use VMDQ+DCB to route traffic to queues */ > + ETH_MQ_RX_VMDQ_DCB = ETH_MQ_RX_VMDQ_FLAG | ETH_MQ_RX_DCB_FLAG, > + /**< Enable both VMDQ and DCB in VMDq */ > + ETH_MQ_RX_VMDQ_DCB_RSS = ETH_MQ_RX_RSS_FLAG | ETH_MQ_RX_DCB_FLAG | > + ETH_MQ_RX_VMDQ_FLAG, Doxygen comments placed before should start with /** not /**<. > + /** Specify the queue range belongs to VMDQ pools if VMDQ applicable. */ > + uint16_t vmdq_queue_base; > + uint16_t vmdq_queue_num; Please explain what mean the values in vmdq_queue_base and vmdq_queue_num. Thanks -- Thomas