DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Wei Huang <wei.huang@intel.com>,
	dev@dpdk.org, rosen.xu@intel.com, qi.z.zhang@intel.com
Cc: stable@dpdk.org, tianfei.zhang@intel.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v12 3/4] raw/ifpga: add fpga helper function
Date: Thu, 28 Jan 2021 13:30:06 +0000	[thread overview]
Message-ID: <48942425-fab3-9357-5ff3-6c06b80f8062@intel.com> (raw)
In-Reply-To: <1611643528-18311-4-git-send-email-wei.huang@intel.com>

On 1/26/2021 6:45 AM, Wei Huang wrote:
> Below helper functions are used to implement OPAE application.
> 1. ifpga_rawdev_lock() and ifpga_rawdev_unlock() protect FPGA access
> in multiproces.

Why driver needs to expose the lock APIs to the application?

Can't application use its own locking mechanism for multiprocess, and driver can 
use its own locking for its needs.
Driver exposing locking internals to applications doesn't look right, but I 
don't know the full usecase.

> 2. ifpga_rawdev_get_rsu_stat() and ifpga_rawdev_set_rsu_stat() record
> current RSU status and progress.
> 3. ifpga_rawdev_get_phy_info() get information of connected retimer.
> 4. ifpga_rawdev_partial_reconfigure() do partial reconfiguration.
> 5. ifpga_rawdev_cleanup() free software resources allocated for driver.
> Signed-off-by: Wei Huang <wei.huang@intel.com>
> Acked-by: Tianfei Zhang <tianfei.zhang@intel.com>
> Acked-by: Rosen Xu <rosen.xu@intel.com>


  reply	other threads:[~2021-01-28 13:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-26  6:45 [dpdk-dev] [PATCH v12 0/4] raw/ifpga: add extra OPAE APIs Wei Huang
2021-01-26  6:45 ` [dpdk-dev] [PATCH v12 1/4] raw/ifpga: add fpga rsu function Wei Huang
2021-01-28 13:24   ` Ferruh Yigit
2021-01-29  7:38     ` Huang, Wei
2021-01-29  8:59       ` Ferruh Yigit
2021-01-26  6:45 ` [dpdk-dev] [PATCH v12 2/4] raw/ifpga: add fpga property get function Wei Huang
2021-01-26  6:45 ` [dpdk-dev] [PATCH v12 3/4] raw/ifpga: add fpga helper function Wei Huang
2021-01-28 13:30   ` Ferruh Yigit [this message]
2021-01-29  7:42     ` [dpdk-dev] [dpdk-stable] " Huang, Wei
2021-01-26  6:45 ` [dpdk-dev] [PATCH v12 4/4] examples/ifpga: add example for ifpga opae API Wei Huang
2021-01-28 13:34   ` Ferruh Yigit
2021-01-29  7:44     ` Huang, Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48942425-fab3-9357-5ff3-6c06b80f8062@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=rosen.xu@intel.com \
    --cc=stable@dpdk.org \
    --cc=tianfei.zhang@intel.com \
    --cc=wei.huang@intel.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).