From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 01CE541E65;
	Fri, 10 Mar 2023 15:22:41 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E60A840A81;
	Fri, 10 Mar 2023 15:22:40 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 9D44240685
 for <dev@dpdk.org>; Fri, 10 Mar 2023 15:22:39 +0100 (CET)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 2214E7B;
 Fri, 10 Mar 2023 17:22:39 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 2214E7B
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1678458159;
 bh=9wwVvpEVhtA4nHenVFVGsg00b9B42mw213bA3mzPzUw=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=vwPdfoVwdooT7mFpqPR03PJjsEassEXQrZ9khehEQD6T8TXYTqv1GhzY/s2cUiZ9o
 Ccrx21bVd2Msi3mGJLtGXUSmKBCkuzYpVbLgYyRTPLpcTWS14Km929l6FvID9aRRTW
 3odOqokZVUPqqImWdN+d9Ns2bKhH5fBZJzlicnzg=
Message-ID: <48a9058e-14e6-db7c-887b-4ead51c3fd48@oktetlabs.ru>
Date: Fri, 10 Mar 2023 17:22:39 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] net/sfc: replace of RTE_LOGTYPE_PMD
Content-Language: en-US
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Cc: Vijay Kumar Srivastava <vsrivast@xilinx.com>
References: <20230223031021.167490-1-stephen@networkplumber.org>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <20230223031021.167490-1-stephen@networkplumber.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 2/23/23 06:10, Stephen Hemminger wrote:
> The static LOGTYPE PMD will go away in the future.
> Replace its use in the sfc driver with the same static
> type as is already used in RTE_LOG_REGISTER macro.
> 
> These drivers are trying to do things that other drivers are not
> in creating log types. IMHO it should follow the other driver
> usage pattern. But this patch leaves the special code.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>