From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] kni: fix ethtool build with kernel 4.11
Date: Wed, 3 May 2017 19:06:46 +0200 [thread overview]
Message-ID: <48ab36d4-db15-4a46-dc8e-03954ed55452@6wind.com> (raw)
In-Reply-To: <cc0171a5-8a6e-11a6-d8e0-ae4b3fa52c4c@intel.com>
Le 03/05/2017 à 18:43, Ferruh Yigit a écrit :
> On 5/3/2017 5:39 PM, Nicolas Dichtel wrote:
>> Le 03/05/2017 à 18:00, Ferruh Yigit a écrit :
>>> build error:
>>> .../build/build/lib/librte_eal/linuxapp/kni/igb_main.c:1034:10:
>>> error: implicit declaration of function ‘pci_enable_msix’
>>> [-Werror=implicit-function-declaration]
>>> err = pci_enable_msix(pdev,
>>> ^~~~~~~~~~~~~~~
>>>
>>> This build error observed when CONFIG_RTE_KNI_KMOD_ETHTOOL config option
>>> enabled.
>>>
>>> Following Linux commit removes the pci_enable_msix()
>>> Linux: 4244de1c64de ("PCI: remove pci_enable_msix")
>>>
>>> Switch to pci_enable_msix_range() for kernel > 4.8 since current Linux
>>> igb driver uses this function.
>> When looking at the kernel patches, it seems that the way to go is to use
>> pci_alloc_irq_vectors(), but it needs a bit more work.
>
> I remember this from your igb_uio fix, but latest igb kernel driver uses
> pci_enable_msix_range(), I found it easy and safe to replicate it.
Ok.
>
> We can update it when kernel igb driver updates the code, unless you
> have a strong opinion to switch pci_alloc_irq_vectors() in advance?
No, I don't mind.
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Regards,
Nicolas
next prev parent reply other threads:[~2017-05-03 17:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 16:00 Ferruh Yigit
2017-05-03 16:39 ` Nicolas Dichtel
2017-05-03 16:43 ` Ferruh Yigit
2017-05-03 17:06 ` Nicolas Dichtel [this message]
2017-05-05 13:46 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48ab36d4-db15-4a46-dc8e-03954ed55452@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).