From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB56941B8E; Tue, 31 Jan 2023 13:25:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A54AB40DFB; Tue, 31 Jan 2023 13:25:16 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B58E64067B for ; Tue, 31 Jan 2023 13:25:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675167914; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KVjKYcd3w+ldXz8vTRNpwQNHuJpPoYUtIe+sTHoidlE=; b=TTu2PLuCAAXtR1hSY3thDUiPvQnJD/MdzXaZ/DxS10pfl1qhk2/5YhkfU6uPVeBkKoDMNV EGzlRTU8GrdlQshEM0vtEad4f+VvC5pIltHnjQN2MDfJb/60+e8quI8+TGegjLrp/6MCQz /iaLHzf5G6ve19KgcpCyLbH80tsOCfg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-556-fY0SAmf8PTK_Ob8TUPNn5A-1; Tue, 31 Jan 2023 07:25:11 -0500 X-MC-Unique: fY0SAmf8PTK_Ob8TUPNn5A-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C447785D063; Tue, 31 Jan 2023 12:25:10 +0000 (UTC) Received: from [10.39.208.22] (unknown [10.39.208.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8CEE2492B05; Tue, 31 Jan 2023 12:25:09 +0000 (UTC) Message-ID: <48b9910d-d060-3fdc-ab20-45d620e790d4@redhat.com> Date: Tue, 31 Jan 2023 13:25:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com References: <20230117165023.20567-1-hernan.vargas@intel.com> <20230117165023.20567-11-hernan.vargas@intel.com> From: Maxime Coquelin Subject: Re: [PATCH v1 10/13] test/bbdev: adjustment for soft output In-Reply-To: <20230117165023.20567-11-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/17/23 17:50, Hernan Vargas wrote: > Extend bbdev-test for soft output check, notably due to the logic in test-bbdev > bbdev-test to enable termination changing. > > Signed-off-by: Hernan Vargas > --- > app/test-bbdev/test_bbdev_perf.c | 26 +++++++++++++------------- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c > index 3b2578baf6..1d18d9e054 100644 > --- a/app/test-bbdev/test_bbdev_perf.c > +++ b/app/test-bbdev/test_bbdev_perf.c > @@ -1348,6 +1348,7 @@ fill_queue_buffers(struct test_op_params *op_params, > RTE_BBDEV_LDPC_LLR_COMPRESSION; > bool harq_comp = op_params->ref_dec_op->ldpc_dec.op_flags & > RTE_BBDEV_LDPC_HARQ_6BIT_COMPRESSION; > + > ldpc_llr_decimals = capabilities->cap.ldpc_dec.llr_decimals; > ldpc_llr_size = capabilities->cap.ldpc_dec.llr_size; > ldpc_cap_flags = capabilities->cap.ldpc_dec.capability_flags; > @@ -2425,7 +2426,7 @@ validate_ldpc_dec_op(struct rte_bbdev_dec_op **ops, const uint16_t n, > i); > > if (ref_op->ldpc_dec.op_flags & RTE_BBDEV_LDPC_SOFT_OUT_ENABLE) > - TEST_ASSERT_SUCCESS(validate_op_chain(soft_output, > + TEST_ASSERT_SUCCESS(validate_op_so_chain(soft_output, > soft_data_orig), > "Soft output buffers (CB=%u) are not equal", > i); > @@ -2495,7 +2496,6 @@ validate_ldpc_enc_op(struct rte_bbdev_enc_op **ops, const uint16_t n, > return TEST_SUCCESS; > } > > - > static inline int > validate_op_fft_chain(struct rte_bbdev_op_data *op, struct op_data_entries *orig_op) > { > @@ -3185,11 +3185,11 @@ throughput_intr_lcore_ldpc_dec(void *arg) > for (j = 0; j < TEST_REPETITIONS; ++j) { > for (i = 0; i < num_to_process; ++i) { > if (!loopback) > - rte_pktmbuf_reset( > - ops[i]->ldpc_dec.hard_output.data); > + rte_pktmbuf_reset(ops[i]->ldpc_dec.hard_output.data); This is not introduced by this patch, but I wonder why not using mbuf_reset() or rte_pktmbuf_reset() everywhere? Looking at the changes below, it seems mbuf_reset() is used for the !loopback case. > if (hc_out || loopback) > - mbuf_reset( > - ops[i]->ldpc_dec.harq_combined_output.data); > + mbuf_reset(ops[i]->ldpc_dec.harq_combined_output.data); > + if (ops[i]->ldpc_dec.soft_output.data != NULL) > + rte_pktmbuf_reset(ops[i]->ldpc_dec.soft_output.data); > } > > tp->start_time = rte_rdtsc_precise(); > @@ -3284,7 +3284,6 @@ throughput_intr_lcore_dec(void *arg) > rte_pktmbuf_reset(ops[i]->turbo_dec.soft_output.data); > } > > - > tp->start_time = rte_rdtsc_precise(); > for (enqueued = 0; enqueued < num_to_process;) { > num_to_enq = burst_sz; > @@ -3746,10 +3745,11 @@ bler_pmd_lcore_ldpc_dec(void *arg) > for (i = 0; i < 1; ++i) { /* Could add more iterations */ > for (j = 0; j < num_ops; ++j) { > if (!loopback) > - mbuf_reset( > - ops_enq[j]->ldpc_dec.hard_output.data); > + mbuf_reset(ops_enq[j]->ldpc_dec.hard_output.data); > if (hc_out || loopback) > mbuf_reset(ops_enq[j]->ldpc_dec.harq_combined_output.data); > + if (ops_enq[j]->ldpc_dec.soft_output.data != NULL) > + mbuf_reset(ops_enq[j]->ldpc_dec.soft_output.data); > } > if (extDdr) > preload_harq_ddr(tp->dev_id, queue_id, ops_enq, > @@ -3981,11 +3981,11 @@ throughput_pmd_lcore_ldpc_dec(void *arg) > for (i = 0; i < TEST_REPETITIONS; ++i) { > for (j = 0; j < num_ops; ++j) { > if (!loopback) > - mbuf_reset( > - ops_enq[j]->ldpc_dec.hard_output.data); > + mbuf_reset(ops_enq[j]->ldpc_dec.hard_output.data); > if (hc_out || loopback) > - mbuf_reset( > - ops_enq[j]->ldpc_dec.harq_combined_output.data); > + mbuf_reset(ops_enq[j]->ldpc_dec.harq_combined_output.data); > + if (ops_enq[j]->ldpc_dec.soft_output.data != NULL) > + mbuf_reset(ops_enq[j]->ldpc_dec.soft_output.data); > } > if (extDdr) > preload_harq_ddr(tp->dev_id, queue_id, ops_enq,