From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id EE7E095CE for ; Tue, 7 Jun 2016 10:15:30 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 07 Jun 2016 01:15:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,432,1459839600"; d="scan'208";a="970418364" Received: from smonroyx-mobl.ger.corp.intel.com (HELO [10.237.220.56]) ([10.237.220.56]) by orsmga001.jf.intel.com with ESMTP; 07 Jun 2016 01:15:29 -0700 To: Slawomir Mrozowicz References: <1465289886-14479-1-git-send-email-slawomirx.mrozowicz@intel.com> Cc: dev@dpdk.org From: Sergio Gonzalez Monroy Message-ID: <48bb7dd9-a8cb-167a-ce7c-868427be578b@intel.com> Date: Tue, 7 Jun 2016 09:15:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1465289886-14479-1-git-send-email-slawomirx.mrozowicz@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: Calling risky function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2016 08:15:31 -0000 On 07/06/2016 09:58, Slawomir Mrozowicz wrote: > lrand48 should not be used for security related applications, > as linear congruential algorithms are too easy to break. > Used a compliant random number generator /dev/urandom. > > Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application") > Coverity ID 124558 > > Signed-off-by: Slawomir Mrozowicz > --- I understand that lrand48 is not crypto secure, but this fix will kill performance. I already have a solution for this issue to be included in the next IPSec patch set that will also add support for GCM/CTR modes. Sergio