From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 7D64DFFA
 for <dev@dpdk.org>; Fri,  3 Feb 2017 12:48:07 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga104.jf.intel.com with ESMTP; 03 Feb 2017 03:48:06 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,328,1477983600"; d="scan'208";a="816631819"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.22.184])
 ([10.252.22.184])
 by FMSMGA003.fm.intel.com with ESMTP; 03 Feb 2017 03:48:04 -0800
To: Pascal Mazon <pascal.mazon@6wind.com>, Keith Wiles <keith.wiles@intel.com>
References: <20170202223330.39240-1-keith.wiles@intel.com>
 <20170203103227.17fc8d66@paques.dev.6wind.com>
Cc: dev@dpdk.org
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <48dccaf1-f951-cb24-0f3d-5831424c7d15@intel.com>
Date: Fri, 3 Feb 2017 11:48:04 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <20170203103227.17fc8d66@paques.dev.6wind.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 1/5] nic/tap: fix tap docs for device name
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Feb 2017 11:48:07 -0000

On 2/3/2017 9:32 AM, Pascal Mazon wrote:
> On Thu,  2 Feb 2017 16:33:26 -0600
> Keith Wiles <keith.wiles@intel.com> wrote:
> 
>> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
>> ---
<...>
> 
> To be consistent. commit title should be "net/tap"
> 
> The patch looks ok to me, but while in the doc, could you fix the "The
> interfaced name" into "The interface name"?

Also checkpatch gives a few long line warnings.

Apart from that, series LGTM too.

> 
> Regards,
> Pascal
>