From: Remy Horton <remy.horton@intel.com>
To: Lei <lei.a.yao@intel.com>, nikhil.rao@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eventdev: change port_id to uint16_t
Date: Thu, 10 May 2018 13:58:07 +0100 [thread overview]
Message-ID: <48eb0898-4cfa-187c-582a-4cc8e5853378@intel.com> (raw)
In-Reply-To: <1525789656-4173-1-git-send-email-lei.a.yao@intel.com>
Would have preferred it if the patch also changed the variable name to
something a bit more descriptive (e.g. port_id, idx_port, ..).
On 08/05/2018 15:27, Lei wrote:
> From: yao <lei.a.yao@intel.com>
>
> From 17.11, port_id is changed from uint8_t to uint16_t.But in eventdev,
> it still use the old fashion. This patch fix this issue.
Reworded using proper tense:
In 17.11 port_id was changed from uint8_t to uint16_t, but eventdev
still uses the old fashion. This patch fixes this issue.
> Signed-off-by: Lei Yao <lei.a.yao@intel.com>
Acked-by: Remy Horton <remy.horton@intel.com>
next prev parent reply other threads:[~2018-05-10 12:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 14:27 Lei
2018-05-10 12:58 ` Remy Horton [this message]
2018-05-10 19:59 ` Ferruh Yigit
2018-05-11 9:00 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48eb0898-4cfa-187c-582a-4cc8e5853378@intel.com \
--to=remy.horton@intel.com \
--cc=dev@dpdk.org \
--cc=lei.a.yao@intel.com \
--cc=nikhil.rao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).