From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 1520B235 for ; Thu, 10 May 2018 14:58:12 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 May 2018 05:58:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,385,1520924400"; d="scan'208";a="54762468" Received: from rhorton-mobl1.ger.corp.intel.com (HELO [163.33.230.88]) ([163.33.230.88]) by orsmga001.jf.intel.com with ESMTP; 10 May 2018 05:58:10 -0700 To: Lei , nikhil.rao@intel.com References: <1525789656-4173-1-git-send-email-lei.a.yao@intel.com> Cc: dev@dpdk.org From: Remy Horton Organization: Intel Shannon Limited Message-ID: <48eb0898-4cfa-187c-582a-4cc8e5853378@intel.com> Date: Thu, 10 May 2018 13:58:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1525789656-4173-1-git-send-email-lei.a.yao@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eventdev: change port_id to uint16_t X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 12:58:13 -0000 Would have preferred it if the patch also changed the variable name to something a bit more descriptive (e.g. port_id, idx_port, ..). On 08/05/2018 15:27, Lei wrote: > From: yao > > From 17.11, port_id is changed from uint8_t to uint16_t.But in eventdev, > it still use the old fashion. This patch fix this issue. Reworded using proper tense: In 17.11 port_id was changed from uint8_t to uint16_t, but eventdev still uses the old fashion. This patch fixes this issue. > Signed-off-by: Lei Yao Acked-by: Remy Horton