DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: stephen@networkplumber.org, "Burakov,
	Anatoly" <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
	Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
	Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
	Dmitry Malloy <dmitrym@microsoft.com>,
	Pallavi Kadam <pallavi.kadam@intel.com>,
	david.marchand@redhat.com, asafp@nvidia.com
Subject: Re: [dpdk-dev] [PATCH v4] eal: detach memsegs on cleanup
Date: Fri, 27 Nov 2020 14:21:22 +0100
Message-ID: <4902592.LPgioPr00H@thomas> (raw)
In-Reply-To: <6ad47d1e-4563-184f-6beb-929e0fea8687@intel.com>

27/11/2020 13:56, Burakov, Anatoly:
> On 22-Nov-20 6:16 PM, Thomas Monjalon wrote:
> > That's a pity we didn't get this patch in DPDK 20.11.
> > 
> > Anatoly, Stephen, what happened? It is not interesting anymore?
> > 
> > Anyone else to review?
> > 
> 
> It is a good patch and should be merged. I wanted to get it into LTS but 
> no such luck apparently.

Anatoly, you must follow-up more closely,
not waiting the last day.

I know it is hard to get any reply from Stephen,
but it is your responsibility.
And I don't understand why nobody else found time to look at it.


> > 20/10/2020 13:53, Thomas Monjalon:
> >> Stephen, ping.
> >>
> >> 15/10/2020 11:54, Burakov, Anatoly:
> >>> On 14-Sep-20 2:04 PM, Anatoly Burakov wrote:
> >>>> Currently, we don't detach the shared memory on EAL cleanup, which
> >>>> leaves the page table descriptors still holding on to the file
> >>>> descriptors as well as memory space occupied by them. Fix it by adding
> >>>> another detach stage that closes the internal memory allocator resource
> >>>> references, detaches shared fbarrays and unmaps the shared mem config.
> >>>>
> >>>> Bugzilla ID: 380
> >>>> Bugzilla ID: 381
> >>>>
> >>>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> >>>> ---
> >>>
> >>> Hi Stephen,
> >>>
> >>> You were the original submitter for the above bugzilla issues. Could you
> >>> please review the patch?




  reply	other threads:[~2020-11-27 13:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-14 11:18 [dpdk-dev] [PATCH] " Anatoly Burakov
2020-09-14 11:26 ` [dpdk-dev] [PATCH v2] " Anatoly Burakov
2020-09-14 11:45   ` [dpdk-dev] [PATCH v3] " Anatoly Burakov
2020-09-14 13:04     ` [dpdk-dev] [PATCH v4] " Anatoly Burakov
2020-10-15  9:54       ` Burakov, Anatoly
2020-10-20 11:53         ` Thomas Monjalon
2020-11-22 18:16           ` Thomas Monjalon
2020-11-27 12:56             ` Burakov, Anatoly
2020-11-27 13:21               ` Thomas Monjalon [this message]
2021-02-11 10:53                 ` Burakov, Anatoly
2021-02-11 16:23       ` Stephen Hemminger
2021-03-03  9:04       ` David Marchand
2021-02-11 13:33   ` [dpdk-dev] [PATCH v2] " Burakov, Anatoly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4902592.LPgioPr00H@thomas \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=asafp@nvidia.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=dmitrym@microsoft.com \
    --cc=navasile@linux.microsoft.com \
    --cc=pallavi.kadam@intel.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git