From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 105D7A0524; Fri, 27 Nov 2020 14:21:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0882DC930; Fri, 27 Nov 2020 14:21:30 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id EADFFC92A for ; Fri, 27 Nov 2020 14:21:27 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 5296C5C0035; Fri, 27 Nov 2020 08:21:26 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 27 Nov 2020 08:21:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= m67sP+/eljeW1sO4Hee73NM+vEg+DYavAVwmY14F4oo=; b=pvkivmCS7xxqq4Z6 bRAN+qZ7tdYQGTfDG3uh+DhGTqGONTBZUKPowqFh6ugh5XGMvWfElaBDxiG7yxiS 7+V9vZe66PC6KrLRWMq4w2NXJjye4FZpzlu73YgpjXNWO1Pi9Z8SHYo4IO8fiskn W3IxbJRxHlYKgWlHcq6XyENpFootDGPpWcweQzCoc/XZXggKYuLtovCN84Qd2mtC AUhDa5zfKdgWUStNF5vCrMOgQFEqsMqOvDGPvt3nAHtfCSed7bb8lxSAX8lp5jlq fi4VskcShG9nW8cOBCG5I2pB/YWI/ewFsV7UPNISUrgCnRTShHZyM3dIQwdlJ/JO xxHZ9g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=m67sP+/eljeW1sO4Hee73NM+vEg+DYavAVwmY14F4 oo=; b=n0PWZST1Rr+5hqck202Kit6Qpc35Cy9LfhKm9jglbuD1b9+w1meyfCW5a IQ82YmTcThTGuireTWmE2URP7zT3rhJFAr97CkxbhG1R6A1RuX8lpU4Ox+CdclYS 0W60KSlKOk0rWsSlCUDsh+oOvuisQqxL11yfalCL3s1mum/gXfcofBBN4UJkdNAp p1TzG3fHnvK1Qo8VV8EsuNldi3JEPhuGigSsFKXmTzrgh+UaAXCogimwNtsI2GDb 2LvRPw7XiFRnADa2Amh3CgTzYsm00EuEHxUpOLl0wrfXD24EyJ8nogHz2+BzJvIC 1fcmC9KP3m+5YFyfrIGV50RhFgbkg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudehgedghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 28567328005A; Fri, 27 Nov 2020 08:21:24 -0500 (EST) From: Thomas Monjalon To: stephen@networkplumber.org, "Burakov, Anatoly" Cc: dev@dpdk.org, Bruce Richardson , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , david.marchand@redhat.com, asafp@nvidia.com Date: Fri, 27 Nov 2020 14:21:22 +0100 Message-ID: <4902592.LPgioPr00H@thomas> In-Reply-To: <6ad47d1e-4563-184f-6beb-929e0fea8687@intel.com> References: <10371462.e6Z5LZp2yc@thomas> <6ad47d1e-4563-184f-6beb-929e0fea8687@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] eal: detach memsegs on cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/11/2020 13:56, Burakov, Anatoly: > On 22-Nov-20 6:16 PM, Thomas Monjalon wrote: > > That's a pity we didn't get this patch in DPDK 20.11. > > > > Anatoly, Stephen, what happened? It is not interesting anymore? > > > > Anyone else to review? > > > > It is a good patch and should be merged. I wanted to get it into LTS but > no such luck apparently. Anatoly, you must follow-up more closely, not waiting the last day. I know it is hard to get any reply from Stephen, but it is your responsibility. And I don't understand why nobody else found time to look at it. > > 20/10/2020 13:53, Thomas Monjalon: > >> Stephen, ping. > >> > >> 15/10/2020 11:54, Burakov, Anatoly: > >>> On 14-Sep-20 2:04 PM, Anatoly Burakov wrote: > >>>> Currently, we don't detach the shared memory on EAL cleanup, which > >>>> leaves the page table descriptors still holding on to the file > >>>> descriptors as well as memory space occupied by them. Fix it by adding > >>>> another detach stage that closes the internal memory allocator resource > >>>> references, detaches shared fbarrays and unmaps the shared mem config. > >>>> > >>>> Bugzilla ID: 380 > >>>> Bugzilla ID: 381 > >>>> > >>>> Signed-off-by: Anatoly Burakov > >>>> --- > >>> > >>> Hi Stephen, > >>> > >>> You were the original submitter for the above bugzilla issues. Could you > >>> please review the patch?