From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id C6F37CF9 for ; Wed, 15 Jul 2015 12:28:19 +0200 (CEST) Received: by widjy10 with SMTP id jy10so124546480wid.1 for ; Wed, 15 Jul 2015 03:28:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=v63LhKrNsJFaNgP8fq+6FGdLmKqnUU34gpugXPz2AGM=; b=BUGCK6XKVGIxb8dtwGuxHRzgXfmT3xk9TMAqkObBj1hG++sSby8UPWho+PJbTe1jup fpFSW+2MzSqIvwxTZdjyoSo4nFdbALlYK9cUVgPTfH+rFYJvhJbpMhySP69bgTvMcfPa JkVV7Y29Axst+pf3317t/657V3jqavJQUE9OGfjyPE9EC5/bsRNsLua3axXYEdwAsE0G jkuBci2q0ZcNv7hIzlrmytNQUv0KAZUlKfWBqNL/+BqrnGZVhaCSsvPeRQ1ZgfQkthdq ckrmOlyhwpJGMojxv0pIzTrMfZ8rVdpvkUzaGC+DlW4r2CNwSJ6QRm3uBy1dAPNyOHnk khgQ== X-Gm-Message-State: ALoCoQlBh8bRrq1Ef8lYep6U1F+P0FhQye5vAGzbt+MYcRMKSBHcYQqzrlavplLqZe2BSYoklt9X X-Received: by 10.180.231.40 with SMTP id td8mr15284353wic.9.1436956099599; Wed, 15 Jul 2015 03:28:19 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.151.210]) by smtp.gmail.com with ESMTPSA id nb9sm8401648wic.10.2015.07.15.03.28.18 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Jul 2015 03:28:18 -0700 (PDT) From: Thomas Monjalon To: "Wang, Liang-min" Date: Wed, 15 Jul 2015 12:27:07 +0200 Message-ID: <4907797.WMXsT5lYd9@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <7196644.zbOgvuZnbg@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v15 1/4] ethdev: add apis to support access device info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jul 2015 10:28:19 -0000 2015-07-15 10:07, Wang, Liang-min: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Please precise offset from which point? > > Why offset is needed? > > > Is C always 0-base? > The offset is introduced because one of the review requesting to support partial register read, > meaning reading single register or a set of registers. > As comment in my reply, this implementation only supports total register dump, > but the data structure design allows future expansion to support this request. OK, so the comment should be something like "Offset in register table" > > What means magic? Is it always a device id? > This field is the same as defined in kernel ethtool data structure. Not an excellent argument :) Actually you didn't answer. > > > --- a/lib/librte_ether/rte_ether_version.map > > > +++ b/lib/librte_ether/rte_ether_version.map > > > @@ -114,5 +114,11 @@ DPDK_2.1 { > > > rte_eth_timesync_enable; > > > rte_eth_timesync_read_rx_timestamp; > > > rte_eth_timesync_read_tx_timestamp; > > > + rte_eth_dev_default_mac_addr_set; > > > + rte_eth_dev_reg_length; > > > + rte_eth_dev_reg_info; > > > + rte_eth_dev_eeprom_length; > > > + rte_eth_dev_get_eeprom; > > > + rte_eth_dev_set_eeprom; > > > > It is not in alphabetical order. > Is there a document on such requirement? No, only emails. Every .map are alphabetically sorted. It's easier to check symbols. > I'm asking this question because different API's are added at different time. > Does this comment apply on relative order or absolute order meaning order relative to mainline code? Relative to mainline. Conflicts are handled when applying.