From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 417241AFEB for ; Wed, 9 May 2018 14:21:22 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BE92E22A35; Wed, 9 May 2018 08:21:21 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 09 May 2018 08:21:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=VmCbO4crWL8kWP80A7VhqcTYzA vMGdDGDd7x8r2/+5M=; b=M69d33EGlSHQgg6/3cpxEMxA+3xnVIwjp7os/KtOaN dvIWaVvGbQetGiyrO9FJ8J6CSTLioritmm+FYJ2iplSuMC7SsebnPYohGNNr5tvw bUK/aNy1OmZacUsOCKU/a9vXjuJCtpffZvcjbwNppxJDxyunapUDltqliOp9VqNM M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=VmCbO4 crWL8kWP80A7VhqcTYzAvMGdDGDd7x8r2/+5M=; b=MZ3Uk1rZV+QnTFnpTUU53Z /qMSKmUVLaer7N8w85E9U/rFwcRE/xUe+sKJYH0ak0GFKtOB9UjPwGIME4gVEIXS Le0BOV0rPQzIaar8z31q8DayF/00uIK8YT+/XCZGa5kxtg3grx5kQn33euc+DiNA 1KVB7WRSKtRbwQgfycJPgGmEdgp/htrZB1BUB857mAIxwE93TxMvyEi+FSb3M14A jkIv9x5HhY9bYhUaSw63Pb3DUDJ0kVB5A3GVazabt5ad8kAj8kbPxqZEi29wYu+1 y0OvpaPsPjPHcwYtstN1d53ZE6etaWK8sLKrqrCL8vMN5YYVOxertanziqOy6N6w == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3EE87E4120; Wed, 9 May 2018 08:21:21 -0400 (EDT) From: Thomas Monjalon To: =?ISO-8859-1?Q?Ga=EBtan?= Rivet Cc: dev@dpdk.org Date: Wed, 09 May 2018 14:21:20 +0200 Message-ID: <4908131.kiA02KnrBr@xps> In-Reply-To: <20180509121320.qpoixqsoxtlcjyak@bidouze.vm.6wind.com> References: <20180509094337.26112-1-thomas@monjalon.net> <20180509094337.26112-3-thomas@monjalon.net> <20180509121320.qpoixqsoxtlcjyak@bidouze.vm.6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH 02/11] net/failsafe: fix sub-device visibility X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 12:21:22 -0000 09/05/2018 14:13, Ga=EBtan Rivet: > I think this patch should be swapped with the next commit > "ethdev: add doxygen comments for each state", > While the comment about "DEFERRED" would be edited in this one to become: > /** The deferred state is deprecated and replaced by ownership. */ > ^^^^^^^^^^ I prefer considering the DEFERRED state as useless in this series. We can discuss about deprecation and removal, separately with a deprecation notice. > Otherwise I agree that the device state is not to be used anymore.