DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ivan Malov <ivan.malov@oktetlabs.ru>,
	David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	Andy Moreton <amoreton@xilinx.com>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] net/sfc: improve logging in MAE backend of RTE flow support
Date: Thu, 15 Jul 2021 15:43:51 +0200	[thread overview]
Message-ID: <4915459.6R0NE6ztUM@thomas> (raw)
In-Reply-To: <CAJFAV8z5NhHQR5wh32xF-m98EBisf0+C-7pnQB2XuO11yWP8pg@mail.gmail.com>

15/07/2021 14:55, David Marchand:
> On Wed, Jul 7, 2021 at 12:56 PM Ivan Malov <ivan.malov@oktetlabs.ru> wrote:
> > diff --git a/drivers/net/sfc/sfc_flow.h b/drivers/net/sfc/sfc_flow.h
> > index bd3b374d68..5b1f34aa7a 100644
> > --- a/drivers/net/sfc/sfc_flow.h
> > +++ b/drivers/net/sfc/sfc_flow.h
> > @@ -136,13 +136,21 @@ typedef int (sfc_flow_item_parse)(const struct rte_flow_item *item,
> >
> >  struct sfc_flow_item {
> >         enum rte_flow_item_type type;           /* Type of item */
> > +       const char *name;                       /* Item name */
> >         enum sfc_flow_item_layers layer;        /* Layer of item */
> >         enum sfc_flow_item_layers prev_layer;   /* Previous layer of item */
> >         enum sfc_flow_parse_ctx_type ctx_type;  /* Parse context type */
> >         sfc_flow_item_parse *parse;             /* Parsing function */
> >  };
> >
> > -int sfc_flow_parse_pattern(const struct sfc_flow_item *flow_items,
> > +#define SFC_FLOW_ITEM(_name) \
> > +       .type = RTE_FLOW_ITEM_TYPE_##_name,     \
> > +       .name = #_name
> 
> Using this concatenation (same for SFC_FLOW_ACTION) confuses
> devtools/parse-flow-support.sh script.
> 
> $ ./devtools/check-doc-vs-code.sh
> rte_flow doc out of sync for sfc
>     item
>     item pf
>     item phy_port
>     item port_id
>     item pppoes
>     item tcp
>     item vf
>     action
> 
> Either net/sfc keeps full RTE_FLOW_x_TYPE_y form like other drivers,
> or the check script must be updated (see exclude/include helpers).

Generating code with macros is also counter-intuitive for grep.
I think it should be avoided and keep full form RTE_FLOW_x_TYPE_y.



  reply	other threads:[~2021-07-15 13:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-07 10:56 [dpdk-dev] [PATCH 1/2] net/sfc: extend " Ivan Malov
2021-07-07 10:56 ` [dpdk-dev] [PATCH 2/2] net/sfc: improve " Ivan Malov
2021-07-15 12:55   ` David Marchand
2021-07-15 13:43     ` Thomas Monjalon [this message]
2021-07-16  2:20 ` [dpdk-dev] [PATCH v2 0/2] RTE flow support logging improvements Ivan Malov
2021-07-16  2:20   ` [dpdk-dev] [PATCH v2 1/2] net/sfc: extend logging in MAE backend of RTE flow support Ivan Malov
2021-07-20 15:45     ` David Marchand
2021-07-16  2:20   ` [dpdk-dev] [PATCH v2 2/2] net/sfc: improve " Ivan Malov
2021-07-21  4:15 ` [dpdk-dev] [PATCH v3 0/2] RTE flow support logging improvements Ivan Malov
2021-07-21  4:15   ` [dpdk-dev] [PATCH v3 1/2] net/sfc: extend logging in MAE backend of RTE flow support Ivan Malov
2021-07-21  4:15   ` [dpdk-dev] [PATCH v3 2/2] net/sfc: improve " Ivan Malov
2021-07-23 21:31   ` [dpdk-dev] [PATCH v3 0/2] RTE flow support logging improvements Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4915459.6R0NE6ztUM@thomas \
    --to=thomas@monjalon.net \
    --cc=amoreton@xilinx.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=ivan.malov@oktetlabs.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).