From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D7ADA04B1; Wed, 23 Sep 2020 12:13:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D1BB21DBA5; Wed, 23 Sep 2020 12:13:00 +0200 (CEST) Received: from mailgw01.pantheon.sk (mailgw01.pantheon.sk [46.229.239.26]) by dpdk.org (Postfix) with ESMTP id 5D05B1DBA0; Wed, 23 Sep 2020 12:12:59 +0200 (CEST) Received: from mailgw01.pantheon.sk (localhost.localdomain [127.0.0.1]) by mailgw01.pantheon.sk (Proxmox) with ESMTP id 055232022FD; Wed, 23 Sep 2020 12:12:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; h=cc:cc:content-transfer-encoding:content-type:content-type :date:from:from:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=dkim; bh=MSbKtFx4XaPzstBqSWyu JyD2l0kbyXgtMGjVfcIsfu8=; b=d1PzVcSjZQIcBdMvvgNupFqiZEp3cf+uHT+l k2M83hcigJRaV8TMwrgxRBRwAkn446Ebdm+g0XwqsFaAkv0KrKSpvSOX/pnMtbr0 q/dERE+Pr6Jao5Uc1MC+pnIwWJ4PujbYiScPTkT8aagYfsp3Tolw/PGJcC3j8idH 8GeIlOnevz/oWOhGzvXT22nzahlbQgtEq8gTiJyQNu8DzOCGFG+x3PW1X1MO/W3u Sak+ny0dYV2uD62p+OfS1T63EZD7I7S46Unzc4q4KD22YV8OioCEDbi1HfhBK3XP 5EczgEcxGTOIwyQ7uxulK4XJlqCLDcAF5+yDEW54V7FQS1ff6A== From: =?iso-8859-2?Q?Juraj_Linke=B9?= To: Phil Yang , "dev@dpdk.org" , "david.marchand@redhat.com" CC: "Ruifeng.Wang@arm.com" , "nd@arm.com" , "stable@dpdk.org" , Bruce Richardson , Luca Boccassi Thread-Topic: [PATCH v2 1/2] devtools: fix ninja install breakage under relative path Thread-Index: AQHWkY2jHA1MXvGMVUOE9We7fByGkKl2AQyg Date: Wed, 23 Sep 2020 10:12:58 +0000 Message-ID: <491d62d04eb24036984ab3016902fc8f@pantheon.tech> References: <1594277585-15281-1-git-send-email-phil.yang@arm.com> <1600854012-10226-1-git-send-email-phil.yang@arm.com> In-Reply-To: <1600854012-10226-1-git-send-email-phil.yang@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.101.4.10] Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/2] devtools: fix ninja install breakage under relative path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Phil Yang > Sent: Wednesday, September 23, 2020 11:40 AM > To: dev@dpdk.org; david.marchand@redhat.com > Cc: Juraj Linke=B9 ; Ruifeng.Wang@arm.com; > nd@arm.com; stable@dpdk.org; Bruce Richardson > ; Luca Boccassi > Subject: [PATCH v2 1/2] devtools: fix ninja install breakage under relati= ve path >=20 > As the DESTDIR variable use as ninja's destination directory when invokin= g ninja > install. If the DESTDIR is not an absolute path, ninja complains. >=20 > Fixes: 777014e56d07 ("devtools: add ABI checks") > Cc: stable@dpdk.org >=20 > Signed-off-by: Phil Yang > --- > v2: > Use readlink to ensure consistent coding style. (Juraj) >=20 > v1: > Initial version. >=20 > devtools/test-meson-builds.sh | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.s= h index > a87de63..5236b9c 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -143,7 +143,8 @@ build () # > > config $srcdir $builds_dir/$targetdir $cross --werror $* > compile $builds_dir/$targetdir > if [ -n "$DPDK_ABI_REF_VERSION" ]; then > - abirefdir=3D${DPDK_ABI_REF_DIR:- > reference}/$DPDK_ABI_REF_VERSION > + abirefdir=3D$(readlink -f \ > + ${DPDK_ABI_REF_DIR:- > reference}/$DPDK_ABI_REF_VERSION) > if [ ! -d $abirefdir/$targetdir ]; then > # clone current sources > if [ ! -d $abirefdir/src ]; then > -- > 2.7.4 >=20 Reviewed-by: Juraj Linke=B9