From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 9F2653977; Thu, 9 May 2019 10:30:00 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1B3FD239B8; Thu, 9 May 2019 04:30:00 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 09 May 2019 04:30:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=eNVtiJiMx8TlGJcvznpa5/3ZX31F+fAbd3EDtDYyCDg=; b=bic0qgBQesG4 sfjsHGWDcWRM5vsf8A8fNjv3y0tRFz0sQWqR2rJn6FWu0jxBR8qlrrV4Bn5rcorj bqE2ZTiSht5ijvziKxTHkNrs1AM4pf4fqyLV0xCPy48d2EdIP5Jo5e9h6oZn9YnK 71wD0HLubOhmslfD6I/J5yExjKgkxnI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=eNVtiJiMx8TlGJcvznpa5/3ZX31F+fAbd3EDtDYyC Dg=; b=wQzAK30apqR/AZFtqYn98vnCxrfpOKrIfeg2IMA6gLc5tZEM64/YRsU1u 1ed91JXRtzHr/QBpHjdy+59GwlJMi9U2jmJx/7u2aKlLrLy8SKSydkVEgcJ1B4ap BKEnIbJ+yIjYJSSDc7A48BocB0bB5/ER7FCA47XsJYw+Ekk/vHx7Fhxy0ssdrypl afN4pKxNvo2P1RE9/ZVsqiEpTl6CBHk4L2Vl7g0tQkLeYkomTqtFAsEfRQ+c3oH3 8qcRZhaaZRFBSrnyN1dH93oBR3tBW3KwcHW//QHApvpVeGcegW3wxlHQMlR4yRGW F2Py50jMRu0VM8k79tZhxWsFZZlZQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrkeehgddthecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0AAE1103D3; Thu, 9 May 2019 04:29:57 -0400 (EDT) From: Thomas Monjalon To: Dharmik Thakkar Cc: stable@dpdk.org, Yipeng Wang , Sameh Gobriel , Bruce Richardson , Pablo de Lara , dev@dpdk.org, honnappa.nagarahalli@arm.com, zhongdahulinfan@163.com Date: Thu, 09 May 2019 10:29:56 +0200 Message-ID: <4921822.WgiOyE7Pmt@xps> In-Reply-To: <20190508225924.21200-2-dharmik.thakkar@arm.com> References: <20190508165121.20471-1-dharmik.thakkar@arm.com> <20190508225924.21200-1-dharmik.thakkar@arm.com> <20190508225924.21200-2-dharmik.thakkar@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/2] hash: fix bugs in 'free key with position' X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 May 2019 08:30:00 -0000 09/05/2019 00:59, Dharmik Thakkar: > This patch fixes 2 bugs- > 1] Incorrect position returned to the free slots. > 2] Incorrect computation of total_entries Is it possible to split in 2 patches? How critical is this bug? It looks old. I'm afraid it will miss 19.05. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id CCD79A0096 for ; Thu, 9 May 2019 10:30:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2A11C4CA0; Thu, 9 May 2019 10:30:04 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 9F2653977; Thu, 9 May 2019 10:30:00 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1B3FD239B8; Thu, 9 May 2019 04:30:00 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 09 May 2019 04:30:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=eNVtiJiMx8TlGJcvznpa5/3ZX31F+fAbd3EDtDYyCDg=; b=bic0qgBQesG4 sfjsHGWDcWRM5vsf8A8fNjv3y0tRFz0sQWqR2rJn6FWu0jxBR8qlrrV4Bn5rcorj bqE2ZTiSht5ijvziKxTHkNrs1AM4pf4fqyLV0xCPy48d2EdIP5Jo5e9h6oZn9YnK 71wD0HLubOhmslfD6I/J5yExjKgkxnI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=eNVtiJiMx8TlGJcvznpa5/3ZX31F+fAbd3EDtDYyC Dg=; b=wQzAK30apqR/AZFtqYn98vnCxrfpOKrIfeg2IMA6gLc5tZEM64/YRsU1u 1ed91JXRtzHr/QBpHjdy+59GwlJMi9U2jmJx/7u2aKlLrLy8SKSydkVEgcJ1B4ap BKEnIbJ+yIjYJSSDc7A48BocB0bB5/ER7FCA47XsJYw+Ekk/vHx7Fhxy0ssdrypl afN4pKxNvo2P1RE9/ZVsqiEpTl6CBHk4L2Vl7g0tQkLeYkomTqtFAsEfRQ+c3oH3 8qcRZhaaZRFBSrnyN1dH93oBR3tBW3KwcHW//QHApvpVeGcegW3wxlHQMlR4yRGW F2Py50jMRu0VM8k79tZhxWsFZZlZQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrkeehgddthecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0AAE1103D3; Thu, 9 May 2019 04:29:57 -0400 (EDT) From: Thomas Monjalon To: Dharmik Thakkar Cc: stable@dpdk.org, Yipeng Wang , Sameh Gobriel , Bruce Richardson , Pablo de Lara , dev@dpdk.org, honnappa.nagarahalli@arm.com, zhongdahulinfan@163.com Date: Thu, 09 May 2019 10:29:56 +0200 Message-ID: <4921822.WgiOyE7Pmt@xps> In-Reply-To: <20190508225924.21200-2-dharmik.thakkar@arm.com> References: <20190508165121.20471-1-dharmik.thakkar@arm.com> <20190508225924.21200-1-dharmik.thakkar@arm.com> <20190508225924.21200-2-dharmik.thakkar@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/2] hash: fix bugs in 'free key with position' X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190509082956.1EXTWOwIpKfqBkdXIwrG57cSDAVUCqNwCWJJ26B3YgU@z> 09/05/2019 00:59, Dharmik Thakkar: > This patch fixes 2 bugs- > 1] Incorrect position returned to the free slots. > 2] Incorrect computation of total_entries Is it possible to split in 2 patches? How critical is this bug? It looks old. I'm afraid it will miss 19.05.