From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E394BA0487 for ; Sat, 6 Jul 2019 18:24:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BB7C44C8F; Sat, 6 Jul 2019 18:24:39 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 74ED2374C; Sat, 6 Jul 2019 18:24:38 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A41AB20E94; Sat, 6 Jul 2019 12:24:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sat, 06 Jul 2019 12:24:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=AsmPS4dKWUQi/poe8ZPFj+6qJxftmIZbRKUcifPt6xA=; b=SqhJCUfJ0Fna OKWt8ag8fJbsPmwPw4QMK3a7te7Iup1iXVlet4M+SDQ+Mx/Ze8k2CMmFBmWT/EVp mHgoNKyew77cuLCsO2juZm+1Z1QjNuaj2g40HUTFVNMefn+xuLYphxeV03Q7fCpD VFDMrgPDC6f59TyFtA9AbgXphTkqmVk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=AsmPS4dKWUQi/poe8ZPFj+6qJxftmIZbRKUcifPt6 xA=; b=Ah2Y1VYfUZ0DFKAGBXDd4yjyHPCh9UsmiAT/RF5grxGBOxRZoyPFk/hnT zmklLsXJXHpQyvbSLyiZEC5vidRO9780dYNO1VZ8VKn0UA0wKQ5LOtYWCqM7f4ym xcx89+LS1jqKqDlgDSZjqGMPhya9zgjrVYBdrNJ4t86FlKp2YM5FmG83rda4fa3y QMvRHA5kF0n3ENGpu2Ws7XMWzNJ0Uh2kvomwjh4uUAHU/o7ld8me+dpZPKZTUPjp xPdr+mckmdeAT+tN7ank66KsPJKSnjfyIBQ9m0Kuzj0lw6eBoSl036GS6ezD6l9E i3EG8es8rehhpPg0+4p/PMvn+X4pw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrfeeigddutddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2E4E4380075; Sat, 6 Jul 2019 12:24:35 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: stable@dpdk.org, Wei Zhao , bernard.iremonger@intel.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, jerinj@marvell.com, konstantin.ananyev@intel.com Date: Sat, 06 Jul 2019 18:24:32 +0200 Message-ID: <4930276.8mQHqxAZBW@xps> In-Reply-To: <1562218537-33583-1-git-send-email-wei.zhao1@intel.com> References: <1562131464-58732-1-git-send-email-wei.zhao1@intel.com> <1562218537-33583-1-git-send-email-wei.zhao1@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/testpmd: fix to add offloads confguration for queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/07/2019 07:35, Wei Zhao: > When adding offloads from commandline, not only port > related configuration bits should be set, but also queue > related offloads configuration bits, or it will cause error. > For example, test in this process for ixgbe: > (1)./x86_64-native-linuxapp-gcc/app/testpmd -c 0x6 -n 4 > -- -i --portmask=0x1 --port-topology=loop --disable-crc-strip > (2)port stop all > (3)port config all crc-strip on > (4)port start all > we will see "Fail to configure port 0 rx queues" of warning info. I'm really surprised it was so much broken. I did not check the code. Someone else did?