From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 1B181591E for ; Mon, 27 Feb 2017 15:18:53 +0100 (CET) Received: by mail-wm0-f51.google.com with SMTP id v186so62396860wmd.0 for ; Mon, 27 Feb 2017 06:18:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=dIFGqLGeaYmIQ+iNMFnaiE4eBRgr9lEiYLOYkXP4/og=; b=h7SVgQ3UdRKIGT/OIFsfeqmhRb5I0zwprMjjgztAt96xqaEvwlilg7RAr6it+1da0g QNIN3mgrFyV8rtAs/wGULnJt8RsM4j/8LENrqo7A6CTz8rSNHdsIfE9INBr2AT6YeKIB iEUWu5jatEZ5i7DKb5jtOkz9V5iO2XXDmWm7vjtB5+zOCmod15Cwh8/Xc67tTbgHq4D8 yV1buhZ6xl/dqXfcTapP78YH31g3nNNn5JDtfbXfNfMQg3DF88WCqe9Hmepaa4Y8Yotq PV3kvINYx9l8Gr4exiwnAr1hwna9D3PITdnhS3TPpbc4MxVMiBF8dCR1TfwvPIlfd/G5 r6YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=dIFGqLGeaYmIQ+iNMFnaiE4eBRgr9lEiYLOYkXP4/og=; b=j90q7T2Vas0SOolFIImACcisJPORlM0U3Sj6HhODlx08vlT5L8tLLhUW3uo3iVYV30 gwn3vbItQqYGgVk/TWwBA7UTWCduOq1YxUHGGQIZyQ5IGfaEXylFGlom20IFTjMlNyap LFmaAc3wh2fLAADh8l6SkZJmYoty9ZpOM1zN8T1cFxVbI3Gakzxyt5FRCZNT0M14kS8y VzQYt3x65/affLy0DmzIIwzBqiLr29+17ezXUBx6p5kKUuU3rIhlB/gne4PZBGvquj7d grv4eG8ESVDkLw/S/BwKC9BRFHF7uYC7fMoraibfLrnHmhJIsBquH9vcF41SlSdSJN2O wp2A== X-Gm-Message-State: AMke39kiYHeyRU9HIw6TE5uOqWwQLZB9oJFtr5tlcm7LmHErGuL7b3jhHzVXD5S8OIWyoIzb X-Received: by 10.28.155.9 with SMTP id d9mr13164742wme.114.1488205133738; Mon, 27 Feb 2017 06:18:53 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id 40sm22482873wry.22.2017.02.27.06.18.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Feb 2017 06:18:53 -0800 (PST) From: Thomas Monjalon To: Jerin Jacob Cc: dev@dpdk.org, ferruh.yigit@intel.com Date: Mon, 27 Feb 2017 15:18:52 +0100 Message-ID: <4940765.paEGL8zfci@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1484642507-15952-1-git-send-email-jerin.jacob@caviumnetworks.com> References: <1480205562-32745-1-git-send-email-jerin.jacob@caviumnetworks.com> <1484642507-15952-1-git-send-email-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] tools: add tags and cscope index file generation support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Feb 2017 14:18:54 -0000 2017-01-17 14:11, Jerin Jacob: > This script generates cscope, gtags, and tags > index files based on EAL environment. > (architecture and OS(linux/bsd)) > > Selection of the architecture and OS environment > is based on dpdk configuration target(T=) What is the purpose of selecting a configuration? Is it to go quicker in the implementation you are interested in? In that case, I think we need a catch-all option, because I like being prompted by vim that several implementations exist and I can choose one of them. > example usage: > make tags T=x86_64-native-linuxapp-gcc > make cscope T=x86_64-native-linuxapp-gcc > make gtags T=x86_64-native-linuxapp-gcc > > Signed-off-by: Jerin Jacob > Reviewed-by: Yuanhan Liu > Reviewed-by: Ferruh Yigit [...] > .gitignore | 8 ++ > devtools/tags.sh | 251 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > mk/rte.sdkroot.mk | 4 + > 3 files changed, 263 insertions(+) I think build-tags.sh would be a better name. On the implementation, I have few comments: - is there a way to re-use the skip list when including the related files? - you can remove tile from this patch And for the details: - why a bash shebang where /bin/sh would be wider? - verbose option should be -v (with getopts) - please use $() instead of backquotes - please avoid one-line functions used only once like doctags I can help you with this script if needed.