From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B55EA0542; Tue, 5 Jul 2022 12:55:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 229604021D; Tue, 5 Jul 2022 12:55:16 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 6AEDC400D7 for ; Tue, 5 Jul 2022 12:55:14 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 0CC285C00EA; Tue, 5 Jul 2022 06:55:14 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 05 Jul 2022 06:55:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1657018514; x= 1657104914; bh=XObB8YoEfb+bHAdXGtItcQTEOPhyNV+4lM2PrdIguNA=; b=B B9HRBBFM1Wbw7Dfp5L5e8DX/ScvXMbXAnu6NKJxIpKrAUyVICKt8I0TGu/GhNyzw +jCTc9RgEt8Q8w3JehhXFIZf9xaiNGEbLvLk+fkt8SMVgOltwUwd/nctOeCORuAO ZXGM/SXIO5XkS7c6EOaKq79hP77RB7X1TM5d13HzDpvBQnZBYq6CVRS5mS1XMD7G bMsnjXJ/7qcVbOCMCVmrBmvbU0NOPIp74A8biwWUfTxQ8gf7DRt6jarh7ydJRguS WhUMHCbYzJHww8LRDuoC12+VRrtKtAnz7yTE59Imx7DatUZ61tn4nNx7ReOVnfM4 TI6hnPdIVl6A3RE425mXQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1657018514; x= 1657104914; bh=XObB8YoEfb+bHAdXGtItcQTEOPhyNV+4lM2PrdIguNA=; b=S JpFVcx7lPm6BcHhG8sP+H6w41IOFHMaMhdMlEyc7nNRE+Aa2G8BdyzOFXZGEzIbT OalddhcZ0fvG2KjeHTNFlnnPMB07j6SqbxMfROPRuBsj3O011plTjVTbvZvrKoQu BaazZi+N/CxZbKdvWv4PmTP4/eMgoqaeG79OX/ubsczbRGhzxDKXDWAQpX4RzEjV 0VFNDMexy+Roy0cYza5Q9cmSLUtq3PDXHI4aecagkFCff9Cpa00rQS8PcN905h2N b5N03JMEaC+KAfnLmwMIdpBxJw27zfwBkn3ykkzlaNRamDcBBAGOnAUJMtIFf9rw EG8LnqmwOoZTEcDWgHK5Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeiuddgfeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeejjefffffgffekfefflefgkeelteejffelledugefhheelffet heevudffudfgvdenucffohhmrghinhepughpughkrdhorhhgnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 5 Jul 2022 06:55:13 -0400 (EDT) From: Thomas Monjalon To: "Ji, Kai" Cc: "dev@dpdk.org" , "gakhil@marvell.com" Subject: Re: [dpdk-dev v1] crypto/openssl: EVP_PKEY routine update in rsa op Date: Tue, 05 Jul 2022 12:55:11 +0200 Message-ID: <4940951.tlMGI8NQbM@thomas> In-Reply-To: References: <20220630103848.36515-1-kai.ji@intel.com> <5501984.rE2NhlSrgm@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 05/07/2022 12:43, Ji, Kai: > From: Thomas Monjalon > > 30/06/2022 12:38, Kai Ji: > > > EVP_PKEY function need to be called twice for rsa sign and verify > > > operations. This patch also remove the OPENSSL_API_COMPAT as all the > > > deprecated APIs are avoid if 3.0 lib is present. > > > > I prefer not pulling this patch for now because it is not clear. > > > > 1/ What is fixed exactly? All RSA sign and verify were broken? > No, this patch fix the 3.0 EVP API in RSA sign and verify routine, original openssl 1.x rsa sign and verify routines are untouched. > The original patch set for Openssl 3.0 EVP API is here: > http://patchwork.dpdk.org/project/dpdk/patch/20220621154214.78176-3-kai.ji@intel.com/ > > > > 2/ Do you mean OpenSSL 3 is required? > No, this branch code will be only executed when Openssl 3.0 lib is detected on the host. OK, please could you reword the commit message so I can apply it to the commit? Thanks