From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 027362B9E for ; Sat, 19 Jan 2019 01:15:32 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 864FB29077; Fri, 18 Jan 2019 19:15:32 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 18 Jan 2019 19:15:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=QOp750URnNLMzUfeZ7fKVk99TDbs2WanMh5DNtA2Eho=; b=DeEeNjkZjoDs y5NBBqm6rNOUSxO9I5346qKg4Qs7kkKkvcDEpoWsas4Zw2AoefT5bsuQnPTeqY6b S4+07Fu0AfG/SS2Ie1aOLMHLnYn70rpiLTuAkYfcwQzYT52/54r69EAQXo++YT0c y9D8T/c9DOQpVetZnahcDC+odmxkLnM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=QOp750URnNLMzUfeZ7fKVk99TDbs2WanMh5DNtA2E ho=; b=bGagsf0L0RNh2JJOIgW7yAMxi34CaQ6h6/J35rgsee+sCqg7yGFsjIb4B kysHosu9Fjp24LiiwCc5ThXFI8+WaGBljPYzummbSrVpflJJ/QDwtR841mTtigSu Jm8/w/M5BuiPK9TpgCQ/Y96lvKjNMQLvGshQKSpfPEmYqNm0mtHQqn50aM2RLuTw M9Ke0iGGMdEN9QqUl68hLx4UFrhih5TyVklKbzdhtm8CfGgdT3tly2Xb4oG0xmcc QI24aDWEzhMtBRwyqZuXfbVoNkyjYwcl0mqr4Q3in2RXw2PckY45zF4I79kPaSdq poEnD2JNpMDQS74odGbT42KCyXMvg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrhedugddukecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfh gggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceo thhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfe drudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7CFD3E4662; Fri, 18 Jan 2019 19:15:30 -0500 (EST) From: Thomas Monjalon To: "Eads, Gage" Cc: dev@dpdk.org, Honnappa Nagarahalli , "olivier.matz@6wind.com" , "arybchenko@solarflare.com" , "Richardson, Bruce" , "Ananyev, Konstantin" , "Gavin Hu (Arm Technology China)" , nd Date: Sat, 19 Jan 2019 01:15:28 +0100 Message-ID: <4946283.tQcWuvKPBh@xps> In-Reply-To: <9184057F7FC11744A2107296B6B8EB1E541C9612@FMSMSX108.amr.corp.intel.com> References: <20190116151835.22424-1-gage.eads@intel.com> <9184057F7FC11744A2107296B6B8EB1E541C9612@FMSMSX108.amr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 2/2] mempool/nb_stack: add non-blocking stack mempool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jan 2019 00:15:33 -0000 19/01/2019 01:00, Eads, Gage: > > > I am wondering if it makes sense to decouple the NB stack data > > > structure from mempool driver (similar to rte_ring)? I see that stack > > > based mempool implements the stack data structure in the driver. But, > > > NB stack might not be such a trivial data structure. It might be > > > useful for the applications or other use cases as well. > > > > > > > I agree -- and you're not the first to suggest this :). > > > > I'm going to defer that work to a later patchset; creating a new lib/ directory > > requires tech board approval (IIRC), which would unnecessarily slow down this > > mempool handler from getting merged. You have time. This patch cannot go in 19.02. You just need to be ready for 19.05-rc1 (more than 2 months). [...] > modularizing nb_lifo can be deferred to the patchset that moves it to a separate library. Please introduce it in the right place from the beginning.