From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F991A04C2; Tue, 11 Aug 2020 15:34:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2110F1C022; Tue, 11 Aug 2020 15:34:15 +0200 (CEST) Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by dpdk.org (Postfix) with ESMTP id 2FB40A3 for ; Tue, 11 Aug 2020 15:34:14 +0200 (CEST) Received: by mail-lf1-f68.google.com with SMTP id j22so6678433lfm.2 for ; Tue, 11 Aug 2020 06:34:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=RSYmx5J+oAY6qlIaNHBzO0wA+OAiodQ9EY7+Bg/yiWs=; b=q9d3J4YAtr1koMUgeD6frKKs34VTupGIickTF4WoK4m3Vec9XnzLhRxJ0BOX989yP0 EFJdHJWCzAKg6+NCjaGu0gRIPiYxsdzx7at8XktlwlXn874NGGJwYJBlY9I9EcQYOLk8 UHTZS1VDLVeFqthMMvXYJNfCqpMDDh1GxbUEmy/ylpuHeg37vtFNIoMezQAZAwOyBueH cMhg8REi2N/0x9QH2GCvnWl11oHU8R2NWLrpexZib2D2QXxPpSkGjdIVbiMFlDCUcaeV UAak6ICoRbHdMtqHqwOl/djCiTyLx/G+8EOPcFndOPBHD9qpaYynY1nsddUdEyAaunWy Fp2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=RSYmx5J+oAY6qlIaNHBzO0wA+OAiodQ9EY7+Bg/yiWs=; b=HmATgol2n7BD/QnbuCul89aUaryJRoo4Wic63BojvCDcdTHEjHOY5ZERuiKGxZZ0th 2zoPBUqKh64nGKAu1HN0ujisp4R0BUN4xyfLeSIPeXsHJrQhjUN69vDoyAVPRiKKYeEe bY3JxUoXERF4+dqxyvv6PXx6Yw/lCLItFOnx6kvew0SVC2yPM4OrPKRTcP04t06DMsek czJIZn9/CYELjs38u257R9WR8TJUZLXQoObpneISVxR9Qt6PkCSxA+tlw6NH8XsUafPK t1v1GxjRpVwHpR8SwhjmQemLDwgEzJqkgH9EphYiYEP+6sjR+xA8Rdlv7CK+9RrsJSKM HuCQ== X-Gm-Message-State: AOAM532xInU+8yY6M63ekAFrrRui/RkBz8CkezKKDvRR1TM7LIsIiC7u fnDaKROCJdpfVmnEIHkvZ6Y= X-Google-Smtp-Source: ABdhPJzipNdzllN1Btb3ST6pPkxnKE/RK9qxeOW/jmE3G1qOAc6185H/8iAQl/lnXUA9t4ZTRg7TXA== X-Received: by 2002:a19:bc1:: with SMTP id 184mr3279441lfl.179.1597152853669; Tue, 11 Aug 2020 06:34:13 -0700 (PDT) Received: from [10.0.0.11] (84-10-19-38.static.chello.pl. [84.10.19.38]) by smtp.googlemail.com with ESMTPSA id x2sm10028480ljc.123.2020.08.11.06.34.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Aug 2020 06:34:13 -0700 (PDT) To: Sunil Kumar Kori , "dev@dpdk.org" Cc: "david.marchand@redhat.com" , Jerin Jacob Kollanukkaran References: <20200804175138.18543-1-pawelwod@gmail.com> <20200810203610.29470-1-pawelwod@gmail.com> From: Pawel Wodkowski Message-ID: <4959ce76-f84d-378f-693e-85ed43116f8c@gmail.com> Date: Tue, 11 Aug 2020 15:34:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [EXT] [PATCH v2] tracepoint: fix compilation with C++ X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Sunil, I finished porting app to DPDK 20.05 and I'm afraid that I can't do anything more here as I don't have proper development environment anymore nor the time for setting it up again. If you find this change useful please take over it. Otherwise there will be long time before I can send next version. Also, as DPDK is deprecating Makefile build system, 20.05 might be last version we are using. Anyway, thanks for guidelines and wish you best. Paweł On 11.08.2020 11:29, Sunil Kumar Kori wrote: > Hello Pawel, > > Few suggestions: > 1. use 'trace' instead of 'tracepoint' in subject line. i.e. "trace: fix compilation with C++" > 1. Update change history. > 2. Add Fixes tag. > 3. Superseed the previous version of this fix. > > Reference: http://patches.dpdk.org/patch/66396/ > Rest Looks okay. Please submit next version with above update. > > Regards > Sunil Kumar Kori > >> -----Original Message----- >> From: Pawel Wodkowski >> Sent: Tuesday, August 11, 2020 2:06 AM >> To: dev@dpdk.org >> Cc: Pawel Wodkowski ; >> david.marchand@redhat.com; Jerin Jacob Kollanukkaran >> ; Sunil Kumar Kori >> Subject: [EXT] [PATCH v2] tracepoint: fix compilation with C++ >> >> External Email >> >> ---------------------------------------------------------------------- >> trace_mem is declared as 'void *' which triggers following error: >> '...invalid conversion from ‘void*’ to ‘__rte_trace_header*’ >> [-fpermissive]...' >> >> Fix this by adding proper typecast to 'struct __rte_trace_header *'. >> >> Signed-off-by: Pawel Wodkowski >> Fixes: ebaee6409702 ("trace: simplify trace point headers") >> Cc: david.marchand@redhat.com >> --- >> lib/librte_eal/include/rte_trace_point.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/lib/librte_eal/include/rte_trace_point.h >> b/lib/librte_eal/include/rte_trace_point.h >> index b45171275..875de195a 100644 >> --- a/lib/librte_eal/include/rte_trace_point.h >> +++ b/lib/librte_eal/include/rte_trace_point.h >> @@ -300,13 +300,13 @@ RTE_DECLARE_PER_LCORE(void *, trace_mem); >> static __rte_always_inline void * __rte_trace_mem_get(uint64_t in) { >> - struct __rte_trace_header *trace = RTE_PER_LCORE(trace_mem); >> + struct __rte_trace_header *trace = (struct __rte_trace_header >> +*)RTE_PER_LCORE(trace_mem); >> const uint16_t sz = in & __RTE_TRACE_FIELD_SIZE_MASK; >> >> /* Trace memory is not initialized for this thread */ >> if (unlikely(trace == NULL)) { >> __rte_trace_mem_per_thread_alloc(); >> - trace = RTE_PER_LCORE(trace_mem); >> + trace = (struct __rte_trace_header *) >> RTE_PER_LCORE(trace_mem); >> if (unlikely(trace == NULL)) >> return NULL; >> } >> -- >> 2.17.1