From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F146B43BBF; Sat, 24 Feb 2024 11:59:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7CE21402C8; Sat, 24 Feb 2024 11:59:09 +0100 (CET) Received: from fhigh8-smtp.messagingengine.com (fhigh8-smtp.messagingengine.com [103.168.172.159]) by mails.dpdk.org (Postfix) with ESMTP id 77278402A8 for ; Sat, 24 Feb 2024 11:59:08 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfhigh.nyi.internal (Postfix) with ESMTP id D16B8114009A; Sat, 24 Feb 2024 05:59:07 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sat, 24 Feb 2024 05:59:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1708772347; x=1708858747; bh=Jg+iMefADNysta/b1EVCWIij8B2IFmvF7x+bppa3Unc=; b= FSzPqUCd27v8bnuF3m/jxbXM4KkoY2We/EduTxCoSnf730EdoDbyUrTzpErL/cYb 8CRdqthY2peuQXDv6ZqfEl6b9rLYimeRdi+PY89hz5e6a21s57rZMYNXdAT1Nw0m 7kzyJxNW2dtQcuCbbxZw4rpCzwI5npvJyq/ScXpp3hXZ4a06hL+iknpi4p8N24Pz Fhr5jmBvdpdn9lTCDKVIEke+5TKt+NW4Z5srmkJtBEv4ru29ZQgbE8oWyhdOnWgU K7QDmhQw5Mmodh36o5RhziukkdyhYjS9n4ozUXJR/1fshH4DvIQ2YwpMqpeBlTrn tMP8mGjj/E+bkJu5wX0ytw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1708772347; x= 1708858747; bh=Jg+iMefADNysta/b1EVCWIij8B2IFmvF7x+bppa3Unc=; b=n oH5VUdW0v1IF9tTSY4j5MHob5OJD3vBdSQY9r+/1hDTX7g0IJhYx12bhhMw1bcOP msJEZdAOl9xhJLA6ykBJEFYLvU/RwHRmG4Rs+0gtnQFgm5ox6LfCMyYJq0Mt+IdL OI7OQZnxJGGl6FS/7nOImdSpP4NJFR4yaconZkNJdFnOnW/AziAh7L56ZX+DSM8S ARbkyMVxcPaAkycTJFfZkq3MBELS3yK2RfOH47Zv6WeeiSN7ZR8B4uiloTUe0Hno fRTFMVPw69en2E3YdZya45KYLKjLB9Ll4AZEascFL8Sq6fe+UfSSxb9xluCvSS5Z tPCIus6cyY53PiDy7e9jg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfeekgddvvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 24 Feb 2024 05:59:00 -0500 (EST) From: Thomas Monjalon To: Tyler Retzlaff Cc: dev@dpdk.org, Ajit Khaparde , Andrew Boyer , Andrew Rybchenko , Bruce Richardson , Chenbo Xia , Chengwen Feng , Dariusz Sosnowski , David Christensen , Hyong Youb Kim , Jerin Jacob , Jie Hai , Jingjing Wu , John Daley , Kevin Laatz , Kiran Kumar K , Konstantin Ananyev , Maciej Czekaj , Matan Azrad , Maxime Coquelin , Nithin Dabilpuram , Ori Kam , Ruifeng Wang , Satha Rao , Somnath Kotur , Suanming Mou , Sunil Kumar Kori , Viacheslav Ovsiienko , Yisen Zhuang , Yuying Zhang , mb@smartsharesystems.com Subject: Re: [PATCH v5 05/22] mbuf: stop using mbuf cacheline marker fields Date: Sat, 24 Feb 2024 11:58:59 +0100 Message-ID: <4970687.0VBMTVartN@thomas> In-Reply-To: <1708762927-14126-6-git-send-email-roretzla@linux.microsoft.com> References: <1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com> <1708762927-14126-1-git-send-email-roretzla@linux.microsoft.com> <1708762927-14126-6-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 24/02/2024 09:21, Tyler Retzlaff: > Update prefetch inline functions to access rte_mbuf struct fields > directly instead of via cacheline{0,1} marker extension fields. > > Signed-off-by: Tyler Retzlaff [...] > rte_mbuf_prefetch_part1(struct rte_mbuf *m) > { > - rte_prefetch0(&m->cacheline0); > + rte_prefetch0(&m->buf_addr); Should be simply "m", no need to point to the first field explicitly. [...] > rte_mbuf_prefetch_part2(struct rte_mbuf *m) > { > #if RTE_CACHE_LINE_SIZE == 64 > - rte_prefetch0(&m->cacheline1); > +#if RTE_IOVA_IN_MBUF > + rte_prefetch0(&m->next); > +#else > + rte_prefetch0(&m->dynfield2); > +#endif I think it is better to calculate m + min cache line size instead of relying on fields.