From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 0D81328C3 for ; Mon, 7 Aug 2017 18:53:08 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A161720D54; Mon, 7 Aug 2017 12:53:07 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 07 Aug 2017 12:53:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=yIsiuac2akRXTp5 hyHDxZ3UPE92go6X6EPD8hr8EJXc=; b=e5w4DvOebIDJq1LjPpySk7r9rK8FTOG 0QkQjBYR/ZroDyJgKTO3DqNrmE1AeW/aoT35aHpMIldHJPBkSuGn1IKL3hjgauqI ICvcfXEFtYDXds5cwxUCoHQw8b7VESaIkTccQG6Uv32IUYRveqDVdnTPcXJQQ90d PxB6Os0bBr/c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=yIsiuac2akRXTp5hyHDxZ3UPE92go6X6EPD8hr8EJXc=; b=OmFdObQO 7nrMePCPhZyNBBN2FC8BVc5ZArAPNZODmR0F3tvpVCFolbM80nV0uNkjSaOOIyCO QgLFGsNRUdeLz6W/p9DkaPZy7r8mmQtOnUBXwPnFa6T4wEzBS+8uPsYZ/hHYN88d 3WRwdYoKSbxVTwFgjQgf2KkK6Gc5Xu7RjojzBz1B3KuGlVMlnkcRjvo/CYfbQIBj XL6SudkZzunRBfPAkIxPHmiGU7PtXLb4Ot3nKk9QE3rp6arJ1aeTlwRfOaWsndNU SVg9clSutJm6ep4dMUOeLumSl4W5T/oJCgrduZUPus4oE8SxemGC+OiE/hzmBQfh 5Vl/kNZcN6x9Cg== X-ME-Sender: X-Sasl-enc: zBMZijp1AqdyI8hyF/1Xi8xU2AHXsa1cLaAfLdw51E1M 1502124587 Received: from xps.localnet (eth-west-pareq2-46-193-0-155.wb.wifirst.net [46.193.0.155]) by mail.messagingengine.com (Postfix) with ESMTPA id 94EE824311; Mon, 7 Aug 2017 12:49:47 -0400 (EDT) From: Thomas Monjalon To: "Wiles, Keith" Cc: dev@dpdk.org Date: Mon, 07 Aug 2017 18:49:09 +0200 Message-ID: <4971244.IkxnILzyaf@xps> In-Reply-To: <2BCD1863-1C9C-422D-83C1-2FFA8673B45A@intel.com> References: <20170706145649.65075-1-keith.wiles@intel.com> <2588998.vour8g1xmE@xps> <2BCD1863-1C9C-422D-83C1-2FFA8673B45A@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] usertools: script to output version string X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Aug 2017 16:53:08 -0000 07/08/2017 15:17, Wiles, Keith: > > > On Aug 7, 2017, at 6:35 AM, Thomas Monjalon wrote: > > > > Hi, > > > > 06/07/2017 16:56, Keith Wiles: > >> +# Locate the rte_version.h file and parse out the version strings. > > > > I think this script is not needed because we have already > > something in mk/rte.sdkconfig.mk. > > Example: > > % make showversion > > 17.08.0-rc4 > > Executing make to find out a version seems to bit of over kill to me and a simple script would be much easier IMO. I do not really see harm in having this script that can output the version into different formats is helpful when running external scripts. Also in the future we are most like going to replace the build system and then we would need to add this support to that build system and having it in a standalone script is easier manage in the long run. "make showversion" is here for several years. Usually we do not implement the same thing in several places without a good reason. And some users can use the old command. Especially when talking about versions, it is very convenient to use the same command in every versions. That's why I insist: why implementing it differently? If it is only about the new build system, it should be part of the build system migration plan (long term).