From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id F10985A44 for ; Thu, 12 Jan 2017 15:18:04 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP; 12 Jan 2017 06:18:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,349,1477983600"; d="scan'208";a="1082187999" Received: from kmsmsx154.gar.corp.intel.com ([172.21.73.14]) by orsmga001.jf.intel.com with ESMTP; 12 Jan 2017 06:18:02 -0800 Received: from pgsmsx109.gar.corp.intel.com (10.221.44.109) by KMSMSX154.gar.corp.intel.com (172.21.73.14) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 12 Jan 2017 22:18:01 +0800 Received: from pgsmsx106.gar.corp.intel.com ([169.254.9.2]) by PGSMSX109.gar.corp.intel.com ([169.254.14.172]) with mapi id 14.03.0248.002; Thu, 12 Jan 2017 22:18:01 +0800 From: "Dai, Wei" To: "Yigit, Ferruh" , "dev@dpdk.org" CC: "Zhang, Helin" , "Ananyev, Konstantin" Thread-Topic: [dpdk-dev] [PATCH 6/7] net/ixgbe/base: add some debug traces Thread-Index: AQHSa1kq7raeUxyb4UeNMvyTOa2JSqEy5MEAgAIAB+A= Date: Thu, 12 Jan 2017 14:18:01 +0000 Message-ID: <49759EB36A64CF4892C1AFEC9231E8D63A327604@PGSMSX106.gar.corp.intel.com> References: <1484063146-15796-1-git-send-email-wei.dai@intel.com> <1484063146-15796-7-git-send-email-wei.dai@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmNlZGM4ODYtNmJiMy00NTcxLTkxMGItYTM2ODUwMWViZTc2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InA0aVdSK243ZHN5YWEzTkk3R3Q5VkMrU3Z2cUhYeWVuYlNkWlpVZlJ1Ykk9In0= x-ctpclassification: CTP_IC x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 6/7] net/ixgbe/base: add some debug traces X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2017 14:18:05 -0000 > -----Original Message----- > From: Yigit, Ferruh > Sent: Wednesday, January 11, 2017 11:39 PM > To: Dai, Wei ; dev@dpdk.org > Cc: Zhang, Helin ; Ananyev, Konstantin > > Subject: Re: [dpdk-dev] [PATCH 6/7] net/ixgbe/base: add some debug traces >=20 > On 1/10/2017 3:45 PM, Wei Dai wrote: > > This patch adds some traces in the reset_hw logic and semaphore > > acquisition logic to help debugging. >=20 > Is verbosity of the PMD changes with this update? >=20 > Is something required in PMD to disable DEBUGOUT1(), DEBUGOUT2(), > DEBUGOUT() by default? In drivers/net/ixgbe/ixgbe_logs.h, there are #ifdef RTE_LIBRTE_IXGBE_DEBUG_DRIVER #define PMD_DRV_LOG_RAW(level, fmt, args...) \ RTE_LOG(level, PMD, "%s(): " fmt, __func__, ## args) #else #define PMD_DRV_LOG_RAW(level, fmt, args...) do { } while (0) #endif And in drivers/net/ixgbe/base/ixgbe_osdep.h, there are #include "../ixgbe_logs.h" .... #define DEBUGOUT(S, args...) PMD_DRV_LOG_RAW(DEBUG, S, ##args) #define DEBUGOUT1(S, args...) DEBUGOUT(S, ##args) #define DEBUGOUT2(S, args...) DEBUGOUT(S, ##args) #define DEBUGOUT3(S, args...) DEBUGOUT(S, ##args) #define DEBUGOUT6(S, args...) DEBUGOUT(S, ##args) #define DEBUGOUT7(S, args...) DEBUGOUT(S, ##args) In config/common_base, there is=20 CONFIG_RTE_LIBRTE_IXGBE_DEBUG_DRIVER=3Dn So according above codes, the macro RTE_LIBRTE_IXGBE_DEBUG_DRIVER in driver= s/net/ixgbe/ixgbe_logs.h is not defined and PMD_DRV_LOG_RAW(level, fmt, args...) do { } while (0) will be valid, then DEBUGOUT() is just a null definition by default. >=20 > > > > Signed-off-by: Wei Dai > > --- >=20 > <...>