From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 35163108F for ; Wed, 25 Jan 2017 02:42:13 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP; 24 Jan 2017 17:42:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,281,1477983600"; d="scan'208";a="56877625" Received: from pgsmsx108.gar.corp.intel.com ([10.221.44.103]) by orsmga005.jf.intel.com with ESMTP; 24 Jan 2017 17:42:10 -0800 Received: from pgsmsx106.gar.corp.intel.com ([169.254.9.9]) by PGSMSX108.gar.corp.intel.com ([169.254.8.13]) with mapi id 14.03.0248.002; Wed, 25 Jan 2017 09:42:09 +0800 From: "Dai, Wei" To: "Dai, Wei" , Yuanhan Liu , Yi Zhang CC: "Zhang, Helin" , "Ananyev, Konstantin" , "dev@dpdk.org" , "Lu, Wenzhuo" Thread-Topic: [dpdk-dev] [PATCH v3] net/ixgbe:fix max packet length in ixgbevf Thread-Index: AQHSVdRJBJZtdTNnQkyAJ89zz0wXk6EGf2CAgEIrsUCAAAGDoA== Date: Wed, 25 Jan 2017 01:42:09 +0000 Message-ID: <49759EB36A64CF4892C1AFEC9231E8D63A355A13@PGSMSX106.gar.corp.intel.com> References: <20161214185019.19581-1-zhang.yi75@zte.com.cn> <20161214070621.GJ18991@yliu-dev.sh.intel.com> <49759EB36A64CF4892C1AFEC9231E8D63A355A02@PGSMSX106.gar.corp.intel.com> In-Reply-To: <49759EB36A64CF4892C1AFEC9231E8D63A355A02@PGSMSX106.gar.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTMzZGMxMGUtNjM1Ny00OGUxLThmZjQtOTY0MDE1ODczYzFmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImpxQ2s0VzViQUNpSHdYVDRERUtvSmNZWGJnbTJwaGRaNHJjb1lnZVc0eVk9In0= x-ctpclassification: CTP_IC x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe:fix max packet length in ixgbevf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jan 2017 01:42:13 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Dai, Wei > Sent: Wednesday, January 25, 2017 9:40 AM > To: Yuanhan Liu ; Yi Zhang > > Cc: Zhang, Helin ; Ananyev, Konstantin > ; dev@dpdk.org; Lu, Wenzhuo > > Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe:fix max packet length in ixg= bevf >=20 > I think your patch does fix an error in ixgbevf and I can acknowledge it = after I > have checked with 82599 and x540 and x550 datasheet. >=20 > In 82599 datasheet, there is an annotation in the chapter 1.3 Features > Summary (page 29) The 82599 supports full-size 15.5 KB (15872-byte) jumb= o > packets while in a basic mode of operation. When DCB mode is enabled, or > security engines enabled or virtualization is enabled, the 82599 supports= 9.5 KB > (9728-byte) jumbo packets >=20 > In x540 datasheet, there is also an annotation in the chapter 1.3 Feature= s > Summary (page 13) The X540 and 82599 support full-size 15.5 KB jumbo > packets while in a basic mode of operation. When DCB mode is enabled, or > security engines enabled, or virtualization is enabled, or OS2BMC is enab= led, > then the X540 supports 9.5 KB jumbo packets. > Packets to/from MC longer than 2KB are filtered out. >=20 > In x550 datasheet, there is still also an annotation in the chapter 1.4 F= eature > Summary (page 23) All the products support full-size 15.5 KB jumbo packet= s > while in a basic mode of operation. When DCB mode is enabled, or security > engines enabled, or virtualization is enabled, or OS2BMC is enabled, then= only > 9.5 KB jumbo packets are supported. Packets to/ from the MC longer than 2= KB > are filtered out. >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yuanhan Liu > > Sent: Wednesday, December 14, 2016 3:06 PM > > To: Yi Zhang > > Cc: Zhang, Helin ; Ananyev, Konstantin > > ; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe:fix max packet length in > > ixgbevf > > > > On Thu, Dec 15, 2016 at 02:50:19AM +0800, Yi Zhang wrote: > > > Current ixgbevf driver get max_rx_pktlen =3D 15872, but in fact PF > > > supports 15872-byte jumbo frame and VF only supports 9728-byte jumbo > > > frame. If VF is running DPDK driver and set frame_size > 9728 ,PF > > > running kernel ixgbe driver will report an error and set VF failed. > > > This patch fixs DPDK ixgbevf driver to get correct jumbo frame size > > > of VF. > > > > > > Signed-off-by: Yi Zhang Acked-by: Wei Dai > > > > Hi, > > > > I saw you have sent this patch 3 times; are you looking for review? > > If so, you should not resend it many times, instead, you could reply > > to your patch if it hasn't got any comments after one week, with > > something like "some one can help review this?", or even a simple "ping= ..." > might just work. > > > > Besides that, you should Cc the corresponding maintainers, but not > > "maintainer@some.org", which is just an example: I doubt such email exi= sts. > > > > You could get the maintainers from the MAINTAINERS. Take ixgbe as > > example, > > it's: > > > > Intel ixgbe > > M: Helin Zhang > > M: Konstantin Ananyev > > F: drivers/net/ixgbe/ > > F: doc/guides/nics/ixgbe.rst > > F: doc/guides/nics/intel_vf.rst > > > > So for this patch, you should at least Cc (or To) Helin and Konstantin. > > I have done that for you this time. > > > > --yliu > > > --- > > > drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > > > b/drivers/net/ixgbe/ixgbe_ethdev.c > > > index edc9b22..573252c 100644 > > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > > > @@ -3168,7 +3168,7 @@ ixgbevf_dev_info_get(struct rte_eth_dev *dev, > > > dev_info->max_rx_queues =3D (uint16_t)hw->mac.max_rx_queues; > > > dev_info->max_tx_queues =3D (uint16_t)hw->mac.max_tx_queues; > > > dev_info->min_rx_bufsize =3D 1024; /* cf BSIZEPACKET in SRRCTL reg = */ > > > - dev_info->max_rx_pktlen =3D 15872; /* includes CRC, cf MAXFRS reg *= / > > > + dev_info->max_rx_pktlen =3D 9728; /* includes CRC, cf MAXFRS reg */ > > > dev_info->max_mac_addrs =3D hw->mac.num_rar_entries; > > > dev_info->max_hash_mac_addrs =3D IXGBE_VMDQ_NUM_UC_MAC; > > > dev_info->max_vfs =3D dev->pci_dev->max_vfs; > > > -- > > > 2.9.3 > > >