DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Dai, Wei" <wei.dai@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Zhang, Helin" <helin.zhang@intel.com>,
	"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: Guo Fengtian <fengtian.guo@6wind.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset
Date: Thu, 9 Feb 2017 14:37:54 +0000	[thread overview]
Message-ID: <49759EB36A64CF4892C1AFEC9231E8D63A3598BC@PGSMSX106.gar.corp.intel.com> (raw)
In-Reply-To: <20170206145858.41447b6e@platinum>

The stats register can rewind to zero when the port is running for a long period.
So I am afraid that this check is not always correct.
Why not introduce a variable to directly indicate whether the resulted stats
should be updated or not.

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Olivier Matz
> Sent: Monday, February 6, 2017 9:59 PM
> To: dev@dpdk.org; Zhang, Helin <helin.zhang@intel.com>; Ananyev,
> Konstantin <konstantin.ananyev@intel.com>
> Cc: Guo Fengtian <fengtian.guo@6wind.com>; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset
> 
> Hi,
> 
> On Wed, 11 Jan 2017 18:04:14 +0100, Olivier Matz <olivier.matz@6wind.com>
> wrote:
> > From: Guo Fengtian <fengtian.guo@6wind.com>
> >
> > When PF is set down, in VF, the value of stats register is zero.
> > So only increase stats when it's non zero.
> >
> > Fixes: af75078fece3 ("first public release")
> >
> > CC: stable@dpdk.org
> > Signed-off-by: Guo Fengtian <fengtian.guo@6wind.com>
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> 
> Ping
> 
> 
> Thanks,
> Olivier

  reply	other threads:[~2017-02-09 14:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-11 17:04 Olivier Matz
2017-02-06 13:58 ` Olivier Matz
2017-02-09 14:37   ` Dai, Wei [this message]
2017-02-09 14:50   ` Dai, Wei
2017-02-16 16:49     ` Olivier Matz
2017-03-14  9:46       ` Olivier Matz
2017-03-24 14:11         ` Olivier Matz
2017-03-28 15:22           ` Thomas Monjalon
2017-03-29  9:22             ` Dai, Wei
2017-03-29 10:08               ` Olivier Matz
2017-03-30 10:46                 ` Dai, Wei
2017-03-30 11:58                   ` Olivier Matz
2017-03-29  9:37             ` Dai, Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49759EB36A64CF4892C1AFEC9231E8D63A3598BC@PGSMSX106.gar.corp.intel.com \
    --to=wei.dai@intel.com \
    --cc=dev@dpdk.org \
    --cc=fengtian.guo@6wind.com \
    --cc=helin.zhang@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).