Re: [dpdk-dev] [PATCH] examples/ip_fragmentation: fix check of packet type

["Dai, Wei" <wei.dai@intel.com>]

> -----Original Message-----
> From: Ananyev, Konstantin
> Sent: Tuesday, March 14, 2017 6:13 AM
> To: Dai, Wei <wei.dai@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: RE: [PATCH] examples/ip_fragmentation: fix check of packet type
> 
> 
> 
> > > Hi Wei,
> > >
> > > >
> > > > Hi, Konstantin
> > > > I see your point.
> > > > I think your method can work.
> > > > But I think your method is a bit complex. As you method need to
> > > > add more
> > > codes.
> > > > Anyway this is a simple bug.
> > > > How do you think now ?
> > >
> > > I still think it is better for all apps to handle this issue in a uniform way.
> > > Again in that case for NICs that do support PTYPE offloads the
> > > performance should be unaffected.
> > > Konstantin
> > >
> >
> > I have just had a quick look through the l3fwd and didn't find any
> > codes to check what ptypes capabilities ae provided by stuff below DPDK
> PMD & its base driver.
> > L3fwd only check an input argument "--parse-ptype" to enable ptype
> > check implemented in a Rx callback function.
> 
> As an example for lpm:
> http://dpdk.org/browse/dpdk/tree/examples/l3fwd/l3fwd_lpm.c#n279
> Konstantin

Thanks for your guide.
I will use rte_eth_dev_get_supported_ptypes( ) in my v2 patch.

> 
> 
> > In this l3fwd rx callback function,  it has done the same thing as my code.
> > Anyway, I'd like to provide a v2 patch to deal with this issue in a uniform way.
> >
> > Thanks & Best Regards
> > -Wei