Re: [dpdk-dev] [PATCH v4 1/3] ethdev: fix adding invalid MAC addr

["Dai, Wei" <wei.dai@intel.com>]

Thanks,  Nelio Laranjeiro.
What about other parts, dear maintainers ?


> -----Original Message-----
> From: Nélio Laranjeiro [mailto:nelio.laranjeiro@6wind.com]
> Sent: Thursday, April 13, 2017 4:45 PM
> To: Dai, Wei <wei.dai@intel.com>
> Cc: thomas.monjalon@6wind.com; harish.patil@cavium.com;
> rasesh.mody@cavium.com; stephen.hurd@broadcom.com;
> ajit.khaparde@broadcom.com; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhang,
> Helin <helin.zhang@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Chen,
> Jing D <jing.d.chen@intel.com>; adrien.mazarguil@6wind.com; Richardson,
> Bruce <bruce.richardson@intel.com>; yuanhan.liu@linux.intel.com;
> maxime.coquelin@redhat.com; dev@dpdk.org; stable@dpdk.org
> Subject: Re: [PATCH v4 1/3] ethdev: fix adding invalid MAC addr
> 
> On Thu, Apr 13, 2017 at 04:21:04PM +0800, Wei Dai wrote:
> > some customers find adding mac addr to VF sometimes can fail, but it
> > is still stored in dev->data->mac_addrs[ ]. So this can lead to some
> > errors that assumes the non-zero entry in
> > dev->data->mac_addrs[ ] is valid.
> >
> > Fixes: af75078fece3 ("first public release")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Wei Dai <wei.dai@intel.com>
> > ---
> >  drivers/net/bnx2x/bnx2x_ethdev.c   |  7 +++++--
> >  drivers/net/bnxt/bnxt_ethdev.c     | 12 ++++++------
> >  drivers/net/e1000/base/e1000_api.c |  2 +-
> >  drivers/net/e1000/em_ethdev.c      |  6 +++---
> >  drivers/net/e1000/igb_ethdev.c     |  5 +++--
> >  drivers/net/enic/enic.h            |  2 +-
> >  drivers/net/enic/enic_ethdev.c     |  4 ++--
> >  drivers/net/enic/enic_main.c       |  6 +++---
> >  drivers/net/fm10k/fm10k_ethdev.c   |  3 ++-
> >  drivers/net/i40e/i40e_ethdev.c     | 11 ++++++-----
> >  drivers/net/i40e/i40e_ethdev_vf.c  |  8 ++++----
> >  drivers/net/ixgbe/ixgbe_ethdev.c   | 27 ++++++++++++++++++---------
> >  drivers/net/mlx4/mlx4.c            | 18 +++++++++++-------
> >  drivers/net/mlx5/mlx5.h            |  4 ++--
> >  drivers/net/mlx5/mlx5_mac.c        | 16 ++++++++++------
> >  drivers/net/qede/qede_ethdev.c     |  6 ++++--
> >  drivers/net/ring/rte_eth_ring.c    |  3 ++-
> >  drivers/net/virtio/virtio_ethdev.c | 13 +++++++------
> >  lib/librte_ether/rte_ethdev.c      | 15 +++++++++------
> >  lib/librte_ether/rte_ethdev.h      |  2 +-
> >  20 files changed, 100 insertions(+), 70 deletions(-)
> >
> 
> 
> For mlx changes,
> 
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> 
> --
> Nélio Laranjeiro
> 6WIND