From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <wei.dai@intel.com> Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 7C2662C27; Sat, 29 Apr 2017 08:09:14 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Apr 2017 23:09:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,391,1488873600"; d="scan'208";a="962493779" Received: from pgsmsx102.gar.corp.intel.com ([10.221.44.80]) by orsmga003.jf.intel.com with ESMTP; 28 Apr 2017 23:09:09 -0700 Received: from pgsmsx106.gar.corp.intel.com ([169.254.9.228]) by PGSMSX102.gar.corp.intel.com ([169.254.6.18]) with mapi id 14.03.0319.002; Sat, 29 Apr 2017 14:09:08 +0800 From: "Dai, Wei" <wei.dai@intel.com> To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>, "harish.patil@cavium.com" <harish.patil@cavium.com>, "rasesh.mody@cavium.com" <rasesh.mody@cavium.com>, "stephen.hurd@broadcom.com" <stephen.hurd@broadcom.com>, "ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com>, "Zhang, Helin" <helin.zhang@intel.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>, "Chen, Jing D" <jing.d.chen@intel.com>, "adrien.mazarguil@6wind.com" <adrien.mazarguil@6wind.com>, "nelio.laranjeiro@6wind.com" <nelio.laranjeiro@6wind.com>, "Richardson, Bruce" <bruce.richardson@intel.com>, "yuanhan.liu@linux.intel.com" <yuanhan.liu@linux.intel.com>, "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com> CC: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org> Thread-Topic: [PATCH v4 1/3] ethdev: fix adding invalid MAC addr Thread-Index: AQHStDAouiaQq/aH706tJdnJ9ZOiNKHO5rcAgA0NnuA= Date: Sat, 29 Apr 2017 06:09:06 +0000 Message-ID: <49759EB36A64CF4892C1AFEC9231E8D650A7836A@PGSMSX106.gar.corp.intel.com> References: <1491987746-10155-1-git-send-email-wei.dai@intel.com> <cover.1492071245.git.wei.dai@intel.com> <6bc635ce8d902ca8b3c6d907a5622febea2f8157.1492071245.git.wei.dai@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B59B6C1@shsmsx102.ccr.corp.intel.com> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B59B6C1@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTVkMjJlOTQtMGY1Ny00ZWVmLWExZGMtYzFiZmY0OGYxOGY5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlFRU0xEdDZydnFjSGF2SklOemlJd2hRRUlaMmw2d0p5UVpFelg4b1dDbnc9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/3] ethdev: fix adding invalid MAC addr X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Sat, 29 Apr 2017 06:09:15 -0000 HI, Wenzhuo > > > > int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int > > wait_to_complete) diff --git a/drivers/net/e1000/base/e1000_api.c > > b/drivers/net/e1000/base/e1000_api.c > > index f7cf83b..dcb53f7 100644 > > --- a/drivers/net/e1000/base/e1000_api.c > > +++ b/drivers/net/e1000/base/e1000_api.c > > @@ -855,7 +855,7 @@ int e1000_rar_set(struct e1000_hw *hw, u8 *addr, > > u32 index) > > if (hw->mac.ops.rar_set) > > return hw->mac.ops.rar_set(hw, addr, index); > > > > - return E1000_SUCCESS; > > + return E1000_ERR_NO_SPACE; > > } > NACK here. Normally we try to avoid changing base code. And I don't think= the > change is necessary. If this code is not changed, the code in ethdev may get wrong return value = and assume the failed MAC addr is added. Anyway, we can ask the base code to be revised by the associated team.