From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id C628D2C37 for ; Fri, 30 Jun 2017 11:37:03 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP; 30 Jun 2017 02:37:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,285,1496127600"; d="scan'208";a="120766676" Received: from pgsmsx102.gar.corp.intel.com ([10.221.44.80]) by fmsmga005.fm.intel.com with ESMTP; 30 Jun 2017 02:37:01 -0700 Received: from kmsmsx153.gar.corp.intel.com ([169.254.5.24]) by PGSMSX102.gar.corp.intel.com ([10.221.44.80]) with mapi id 14.03.0319.002; Fri, 30 Jun 2017 17:37:00 +0800 From: "Dai, Wei" To: "Wu, Jingjing" , "thomas@monjalon.net" , "Lu, Wenzhuo" , "Ananyev, Konstantin" , "Zhang, Helin" , "Peng, Yuan" CC: "dev@dpdk.org" Thread-Topic: [PATCH v4 3/5] net/i40e: add support of reset Thread-Index: AQHS8O89emULBbL7fUOz/F5cakmZ2KI8lPeAgACOdGA= Date: Fri, 30 Jun 2017 09:37:00 +0000 Message-ID: <49759EB36A64CF4892C1AFEC9231E8D650B4C8DD@KMSMSX153.gar.corp.intel.com> References: <20170629083404.1271-1-wei.dai@intel.com> <1498748282-69914-1-git-send-email-wei.dai@intel.com> <1498748282-69914-4-git-send-email-wei.dai@intel.com> <9BB6961774997848B5B42BEC655768F810DB7541@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F810DB7541@SHSMSX103.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2ZhOGRlYzItODE0Mi00OTZjLWFjMTQtNzljYTcwNTUxODBmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjhzdWRBNENtRVY4UmFTZktXZGp0b0RFR2JPc00xaURwQ2JcL0ZSWlIwaHhnPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 3/5] net/i40e: add support of reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jun 2017 09:37:04 -0000 > -----Original Message----- > From: Wu, Jingjing > Sent: Friday, June 30, 2017 4:54 PM > To: Dai, Wei ; thomas@monjalon.net; Lu, Wenzhuo > ; Ananyev, Konstantin > ; Zhang, Helin ; > Peng, Yuan > Cc: dev@dpdk.org > Subject: RE: [PATCH v4 3/5] net/i40e: add support of reset >=20 > > } > > > > +static int > > +i40e_dev_reset(struct rte_eth_dev *dev) { > > + int ret; > > + > > + ret =3D eth_i40e_dev_uninit(dev); > > + if (ret) > > + return ret; > > + > > + ret =3D eth_i40e_dev_init(dev); > > + > > + return ret; > Have you thought about if DPDK is working as host driver, and there Are V= Fs > rely on it? If it doesn't support, at least a check should be added. > Or you can add those check in Rte level. If there is any VF, PF reset need sync with VF, but sync method may be much= different with different NIC type. So, we'd like first reject PF reset if its VF exist. I'll update it in v5 patch set. >=20 > Thanks > Jingjing