From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id AF7B92BBE for ; Thu, 13 Jul 2017 18:06:52 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP; 13 Jul 2017 09:06:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,354,1496127600"; d="scan'208";a="124776951" Received: from kmsmsx154.gar.corp.intel.com ([172.21.73.14]) by orsmga005.jf.intel.com with ESMTP; 13 Jul 2017 09:06:50 -0700 Received: from pgsmsx106.gar.corp.intel.com ([169.254.9.158]) by KMSMSX154.gar.corp.intel.com ([169.254.12.48]) with mapi id 14.03.0319.002; Fri, 14 Jul 2017 00:06:49 +0800 From: "Dai, Wei" To: Jerin Jacob CC: "thomas@monjalon.net" , "Lu, Wenzhuo" , "Ananyev, Konstantin" , "Wu, Jingjing" , "Xing, Beilei" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v6 1/4] ethdev: add support of NIC reset Thread-Index: AQHS+WWa1PmUN361mUavg2CqZl6Kd6JMaEGAgAFxpSD//7cNAIAEX92Q Date: Thu, 13 Jul 2017 16:06:48 +0000 Message-ID: <49759EB36A64CF4892C1AFEC9231E8D650B62A2C@PGSMSX106.gar.corp.intel.com> References: <1498817556-64379-1-git-send-email-wei.dai@intel.com> <1499681144-26031-1-git-send-email-wei.dai@intel.com> <1499681144-26031-2-git-send-email-wei.dai@intel.com> <20170710113506.GA17339@jerin> <49759EB36A64CF4892C1AFEC9231E8D650B60DC0@PGSMSX106.gar.corp.intel.com> <20170711051701.GA5637@jerin> In-Reply-To: <20170711051701.GA5637@jerin> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 1/4] ethdev: add support of NIC reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Jul 2017 16:06:53 -0000 > > Subject: RE: [dpdk-dev] [PATCH v6 1/4] ethdev: add support of NIC > > reset > > > > > > > + * A DPDK application also can call this function to trigger an > > > + initative > > > + * port reset. > > > > When apart from the above use case? Even if it is above case, we should > have some event to notify application to initiate the reset.Right? Withou= t > the event, When or on what basics application needs to initiate reset? > > [Wei: Indeed, until now we didn't see any use case which DPDK applicati= on > initiative port reset itself. > > The most usual case is that PF is working with kernel driver and VFs ar= e > working with DPDK PMD. > > Some operations on kernel PF lead to a PF reset which causes its VF res= et. > > Anyway this new function provides a possibility for application to > > trigger an initiative port reset.] >=20 > That's fine. The only concern part is when to call reset API from applica= tion. > Can we say on RTE_ETH_EVENT_INTR_RESET event, application needs to > call the reset API? I think, it is important to specify when application = need to > call this API, otherwise this api behavior will be tightly coupled with > underneath PMD. Side effect is, a new, non portable PMD specific API. > If a PMD wishes to fixup some overflow case(as an example), by invoking t= he > reset API from the application BUT same case may not valid for another > PMD hence it will create unexpected behavior from application based on th= e > underneath PMD. >=20 > if RTE_ETH_EVENT_INTR_RESET event is not expected event to call the reset > API then create a new event or if it needs to be called in > RTE_ETH_EVENT_INTR_RESET then update the API documentation. Thanks for your feedback. I'll add description of this function in API doc in my v7 patch set. >=20 > > > > > + *