From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id D2CD42030 for ; Wed, 19 Jul 2017 16:36:38 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jul 2017 07:36:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,381,1496127600"; d="scan'208";a="126939648" Received: from pgsmsx107.gar.corp.intel.com ([10.221.44.105]) by orsmga005.jf.intel.com with ESMTP; 19 Jul 2017 07:36:36 -0700 Received: from pgsmsx106.gar.corp.intel.com ([169.254.9.158]) by PGSMSX107.gar.corp.intel.com ([10.221.44.105]) with mapi id 14.03.0319.002; Wed, 19 Jul 2017 22:36:35 +0800 From: "Dai, Wei" To: Thomas Monjalon , "Horton, Remy" CC: "dev@dpdk.org" , "Lu, Wenzhuo" , "Ananyev, Konstantin" , "Wu, Jingjing" , "Xing, Beilei" , "Mcnamara, John" Thread-Topic: [dpdk-dev] [PATCH v7 0/5] Support NIC reset and keep same port id Thread-Index: AQHS+/HWedMRvUtg8E6FBCslNQGQxaJWVJcAgATqniA= Date: Wed, 19 Jul 2017 14:36:35 +0000 Message-ID: <49759EB36A64CF4892C1AFEC9231E8D650B6520D@PGSMSX106.gar.corp.intel.com> References: <1499681144-26031-1-git-send-email-wei.dai@intel.com> <1499961223-45281-1-git-send-email-wei.dai@intel.com> <8733823.mcBcVaCldc@xps> In-Reply-To: <8733823.mcBcVaCldc@xps> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTU1MGMwMTItNzNmMS00NjM5LTg4ZDktNDIyYmVjMWQ4MzA3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjUrSE92N0N3aE9tY0JpZ3FGekR4TlFBTUgwTDRnUUJFakp2VE4wWDVCcXM9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 0/5] Support NIC reset and keep same port id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jul 2017 14:36:39 -0000 Remy is a Native English speaker. He will help me review my v8 patch set. Thank you, Remy. > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Monday, July 17, 2017 3:26 AM > To: Dai, Wei > Cc: dev@dpdk.org; Lu, Wenzhuo ; Ananyev, > Konstantin ; Wu, Jingjing > ; Xing, Beilei ; Mcnamara, > John > Subject: Re: [dpdk-dev] [PATCH v7 0/5] Support NIC reset and keep same > port id >=20 > 13/07/2017 17:53, Wei Dai: > > chagnes: > > v7: > > add description of NIC reset in doc/poll_mode_drv.rst >=20 > Thanks for bringing more explanations. > The texts have to be reviewed by a native english speaker. >=20 > About the organization of the doc, it is good to explain the VF use case = in the > prog guide as you do. But you should not add it to the doxygen. > The doxygen must be concise enough and explains only the API: > - when it can be called > - what a driver is doing when calling reset > - what is the expected state of the device after reset