From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id C77C21B1BF; Wed, 11 Oct 2017 09:07:30 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Oct 2017 00:07:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,360,1503385200"; d="scan'208";a="1229487366" Received: from kmsmsx154.gar.corp.intel.com ([172.21.73.14]) by fmsmga002.fm.intel.com with ESMTP; 11 Oct 2017 00:07:28 -0700 Received: from pgsmsx109.gar.corp.intel.com (10.221.44.109) by KMSMSX154.gar.corp.intel.com (172.21.73.14) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 11 Oct 2017 15:07:13 +0800 Received: from pgsmsx106.gar.corp.intel.com ([169.254.9.199]) by PGSMSX109.gar.corp.intel.com ([169.254.14.159]) with mapi id 14.03.0319.002; Wed, 11 Oct 2017 15:07:13 +0800 From: "Dai, Wei" To: "Ma, Jianwei" , "Lu, Wenzhuo" , "Ananyev, Konstantin" , "Liang, Cunming" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/ixgbe: fix VFIO interrupt mapping in VF Thread-Index: AQHTOANGW7Fo0QsyfkypcsjBytCSCaLcf8Jg///S5gCAAfu+kA== Date: Wed, 11 Oct 2017 07:07:13 +0000 Message-ID: <49759EB36A64CF4892C1AFEC9231E8D650BA0263@PGSMSX106.gar.corp.intel.com> References: <1505902146-50272-1-git-send-email-wei.dai@intel.com> <1506565713-70534-1-git-send-email-wei.dai@intel.com> <49759EB36A64CF4892C1AFEC9231E8D650B9FCA4@PGSMSX106.gar.corp.intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTE5MTk2ZTctNjcwZC00NWQxLThiOTQtZWJiMTNhZGVhY2IzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjFFZFNoSWltMERvNjdLU2Jic3E3OG1SeTVwRnJUblREaVYzSWFRQURCcjQ9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix VFIO interrupt mapping in VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Oct 2017 07:07:31 -0000 I look through from web browser and not find following mail from Jianwei Ma= Hope this can add his test result in the mail list to community. > -----Original Message----- > From: Ma, Jianwei > Sent: Tuesday, October 10, 2017 4:47 PM > To: Dai, Wei ; Lu, Wenzhuo ; > Ananyev, Konstantin ; Liang, Cunming > > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH v2] net/ixgbe: fix VFIO interrupt mapping in VF >=20 > Verified with l3fwd-power. It worked well with this patch plus > http://dpdk.org/dev/patchwork/patch/29000/ " [dpdk-dev] net/ixgbe: fix > Rx queue interrupt mapping in VF" >=20 > -----Original Message----- > From: Dai, Wei > Sent: Tuesday, October 10, 2017 11:30 > To: Lu, Wenzhuo ; Ananyev, Konstantin > ; Liang, Cunming > ; Ma, Jianwei > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH v2] net/ixgbe: fix VFIO interrupt mapping in VF >=20 > Hi, Jianwei > How about your test result ? >=20 > Hi Wenzhuo > Would you please review this patch ? >=20 > Thanks a lot ! >=20 > > -----Original Message----- > > From: Dai, Wei > > Sent: Thursday, September 28, 2017 10:29 AM > > To: Lu, Wenzhuo ; Ananyev, Konstantin > > ; Liang, Cunming > > ; Ma, Jianwei > > Cc: dev@dpdk.org; Dai, Wei ; stable@dpdk.org > > Subject: [PATCH v2] net/ixgbe: fix VFIO interrupt mapping in VF > > > > When a VF port is bound to VFIO-PIC, only miscellaneous interrupt is > > mapped to VFIO vector 0 in eth_ixgbevf_dev_init( ). > > In ixgbevf_dev_start(), if previous VFIO interrupt mapping set in > > eth_ixgbevf_dev_init( ) is not cleard, it will fail when calling > > rte_intr_enable( ) tries to map Rx queue interrupt to other VFIO > > vectors. This patch clears the VFIO interrupt mappings before setting > > both miscellaneous and Rx queue interrupt mappings again to avoid > failure. > > > > Fixes: 77234603fba0 ("net/ixgbe: support VF mailbox interrupt for link > > up/down") > > Cc: stable@dpdk.org > > > > Signed-off-by: Wei Dai > Tested-by: Jianwei Ma > > --- > > drivers/net/ixgbe/ixgbe_ethdev.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > > b/drivers/net/ixgbe/ixgbe_ethdev.c > > index 9ca5cbc..f49c616 100644 > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > > @@ -5046,6 +5046,15 @@ ixgbevf_dev_start(struct rte_eth_dev *dev) > > } > > ixgbevf_configure_msix(dev); > > > > + /* When a VF port is bound to VFIO-PCI, only miscellaneous interrupt > > + * is mapped to VFIO vector 0 in eth_ixgbevf_dev_init( ). > > + * If previous VFIO interrupt mapping setting in eth_ixgbevf_dev_init= ( ) > > + * is not cleared, it will fail when following rte_intr_enable( ) tri= es > > + * to map Rx queue interrupt to other VFIO vectors. > > + * So clear uio/vfio intr/evevnfd first to avoid failure. > > + */ > > + rte_intr_disable(intr_handle); > > + > > rte_intr_enable(intr_handle); > > > > /* Re-enable interrupt for VF */ > > -- > > 2.7.5