From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 3AF76237; Thu, 28 Dec 2017 05:38:37 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Dec 2017 20:38:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,469,1508828400"; d="scan'208";a="162250830" Received: from pgsmsx108.gar.corp.intel.com ([10.221.44.103]) by orsmga004.jf.intel.com with ESMTP; 27 Dec 2017 20:38:35 -0800 Received: from pgsmsx112.gar.corp.intel.com ([169.254.3.145]) by PGSMSX108.gar.corp.intel.com ([169.254.8.194]) with mapi id 14.03.0319.002; Thu, 28 Dec 2017 12:38:34 +0800 From: "Dai, Wei" To: "Zhang, Qi Z" , "Lu, Wenzhuo" CC: "dev@dpdk.org" , "Wang, Liang-min" , "stable@dpdk.org" Thread-Topic: [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler Thread-Index: AQHTf4x1Ad0uO+V2Nk2kOE+LoAm2TqNYKJYQ Date: Thu, 28 Dec 2017 04:38:34 +0000 Message-ID: <49759EB36A64CF4892C1AFEC9231E8D65156D94A@PGSMSX112.gar.corp.intel.com> References: <1514406150-17517-1-git-send-email-qi.z.zhang@intel.com> In-Reply-To: <1514406150-17517-1-git-send-email-qi.z.zhang@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYThjNGY0YmEtN2I2ZS00Y2Q3LWI3NWQtNDE4ODBkODg1Mzc1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InZlV1JhQmdJV0JsTXdtaTRNQ0syeFRFMFdodDRhb09qTytLQStLVHFvQXM9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Dec 2017 04:38:38 -0000 According to step 7 & 8 in Table 7-74 PF-to-VF Messaging Flow in 82599 data= sheet, The calling of ixgbe_read_mbx( ) can be replaced by following lines to avoi= d touching ->mbx.v2p_mailbox, IXGBE_WRITE_REG(hw, IXGBE_VFMAILBOX, IXGBE_VFMAILBOX_ACK); > -----Original Message----- > From: Zhang, Qi Z > Sent: Thursday, December 28, 2017 4:22 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Dai, Wei ; Wang, Liang-min > ; Zhang, Qi Z ; > stable@dpdk.org > Subject: [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler >=20 > Mailbox interrupt handler only take care of PF reset notification, for ot= her > message ixgbe_read_mbx should not be called since it get chance to break > the foreground VF to PF communication. > This can be simply repeated by > testpmd>rx_vlan rm all 0 >=20 > Fixes: 77234603fba0 ("net/ixgbe: support VF mailbox interrupt for link > up/down") > Cc: stable@dpdk.org >=20 > Signed-off-by: Qi Zhang > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index ff19a56..02121f4 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -8165,13 +8165,17 @@ static void ixgbevf_mbx_process(struct > rte_eth_dev *dev) > struct ixgbe_hw *hw =3D > IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private); > u32 in_msg =3D 0; >=20 > - if (ixgbe_read_mbx(hw, &in_msg, 1, 0)) > - return; > + /* peek the message first */ > + in_msg =3D IXGBE_READ_REG(hw, IXGBE_VFMBMEM); >=20 > /* PF reset VF event */ > - if (in_msg =3D=3D IXGBE_PF_CONTROL_MSG) > + if (in_msg =3D=3D IXGBE_PF_CONTROL_MSG) { > + /* dummy mbx read to ack pf */ > + if (ixgbe_read_mbx(hw, &in_msg, 1, 0)) > + return; > _rte_eth_dev_callback_process(dev, > RTE_ETH_EVENT_INTR_RESET, > NULL, NULL); > + } > } >=20 > static int > -- > 2.7.4