From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id BF67216E; Fri, 12 Jan 2018 03:32:47 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2018 18:32:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,347,1511856000"; d="scan'208";a="26512165" Received: from pgsmsx102.gar.corp.intel.com ([10.221.44.80]) by orsmga002.jf.intel.com with ESMTP; 11 Jan 2018 18:32:45 -0800 Received: from pgsmsx112.gar.corp.intel.com ([169.254.3.86]) by PGSMSX102.gar.corp.intel.com ([169.254.6.144]) with mapi id 14.03.0319.002; Fri, 12 Jan 2018 10:32:44 +0800 From: "Dai, Wei" To: "Zhang, Qi Z" , "Lu, Wenzhuo" CC: "dev@dpdk.org" , "Wang, Liang-min" , "stable@dpdk.org" Thread-Topic: [PATCH 2/2] net/e1000: fix mailbox interrupt handler Thread-Index: AQHTf4x4tRTGuI+9TUamZOcHRIz3YqNvnA5w Date: Fri, 12 Jan 2018 02:32:44 +0000 Message-ID: <49759EB36A64CF4892C1AFEC9231E8D66CF219AC@PGSMSX112.gar.corp.intel.com> References: <1514406150-17517-1-git-send-email-qi.z.zhang@intel.com> <1514406150-17517-2-git-send-email-qi.z.zhang@intel.com> In-Reply-To: <1514406150-17517-2-git-send-email-qi.z.zhang@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTU3YjlkNDAtMDY1ZC00ZjljLTkxNzUtOGEwOTNiMjI5NWEwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjFPK1A4bG8zbkIrVHFHRXpxUWVDbFM4K0ttXC9HcUR6QUZUN1pWVXZpYU1zPSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/2] net/e1000: fix mailbox interrupt handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2018 02:32:48 -0000 > -----Original Message----- > From: Zhang, Qi Z > Sent: Thursday, December 28, 2017 4:23 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Dai, Wei ; Wang, Liang-min > ; Zhang, Qi Z ; > stable@dpdk.org > Subject: [PATCH 2/2] net/e1000: fix mailbox interrupt handler >=20 > Mailbox interrupt handler only take care of the PF reset notification, fo= r > other message mbx->ops.read should not be called since it get chance to > break the foreground VF to PF communication. >=20 > Fixes: 316f4f1adc2e ("net/igb: support VF mailbox interrupt for link > up/down") > Cc: stable@dpdk.org >=20 > Signed-off-by: Qi Zhang Acked-by: Wei Dai > --- > drivers/net/e1000/igb_ethdev.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/e1000/igb_ethdev.c > b/drivers/net/e1000/igb_ethdev.c index fdc139f..0d8bc49 100644 > --- a/drivers/net/e1000/igb_ethdev.c > +++ b/drivers/net/e1000/igb_ethdev.c > @@ -2970,13 +2970,17 @@ void igbvf_mbx_process(struct rte_eth_dev > *dev) > struct e1000_mbx_info *mbx =3D &hw->mbx; > u32 in_msg =3D 0; >=20 > - if (mbx->ops.read(hw, &in_msg, 1, 0)) > - return; > + /* peek the message first */ > + in_msg =3D E1000_READ_REG(hw, E1000_VMBMEM(0)); >=20 > /* PF reset VF event */ > - if (in_msg =3D=3D E1000_PF_CONTROL_MSG) > + if (in_msg =3D=3D E1000_PF_CONTROL_MSG) { > + /* dummy mbx read to ack pf */ > + if (mbx->ops.read(hw, &in_msg, 1, 0)) > + return; > _rte_eth_dev_callback_process(dev, > RTE_ETH_EVENT_INTR_RESET, > NULL, NULL); > + } > } >=20 > static int > -- > 2.7.4