From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 47FEE1B00C for ; Mon, 22 Jan 2018 08:03:03 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jan 2018 23:03:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,395,1511856000"; d="scan'208";a="197488219" Received: from pgsmsx106.gar.corp.intel.com ([10.221.44.98]) by fmsmga005.fm.intel.com with ESMTP; 21 Jan 2018 23:03:02 -0800 Received: from pgsmsx112.gar.corp.intel.com ([169.254.3.86]) by PGSMSX106.gar.corp.intel.com ([169.254.9.199]) with mapi id 14.03.0319.002; Mon, 22 Jan 2018 15:03:01 +0800 From: "Dai, Wei" To: "Yang, Qiming" , "Lu, Wenzhuo" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] net/ixgbe: fix VFIO interrupt mapping in PF Thread-Index: AQHTidxMaJeG546F/U+aTMI2I+xKeaN/iHgg Date: Mon, 22 Jan 2018 07:03:01 +0000 Message-ID: <49759EB36A64CF4892C1AFEC9231E8D66CF24A21@PGSMSX112.gar.corp.intel.com> References: <1505903043-51967-1-git-send-email-wei.dai@intel.com> <1515486230-77436-1-git-send-email-wenzhuo.lu@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGVhNDJiZjEtMjI2Yy00YWI5LTg1YzUtMmEyMmU3NGRiZDQ4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjZ4Skp1b3BmOVJsWWUxZUx0R2FoaG14K0dkbkRIc1RxenZIYkRXUzBDZG89In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] net/ixgbe: fix VFIO interrupt mapping in PF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2018 07:03:04 -0000 I add this code line to align same style and same action taken in ixgbe VF = and i40e VF. In ixgbe VF or i40e VF, without this line, the initialization of Rx queue = interrupt mapping to VFIO-PCI vectors would fail. I have tested it in ixgbe PF port with example/l3fwd-power and=20 found the interrupt can be initialized successfully and Rx queue can be wak= ed up by incoming packets no matter whether this line exists or not. So I decide to reject it now. > -----Original Message----- > From: Yang, Qiming > Sent: Wednesday, January 10, 2018 2:29 PM > To: Lu, Wenzhuo ; Dai, Wei > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] net/ixgbe: fix VFIO interrupt mapping in PF >=20 > +1 why we disable interrupt in dev_start twice? >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > > Sent: Tuesday, January 9, 2018 4:24 PM > > To: Dai, Wei > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] net/ixgbe: fix VFIO interrupt mapping in PF > > > > Hi Wei, > > > > > + rte_intr_disable(intr_handle); > > TBH, confused by this patch. I see the intr already disabled at the > > begining of this function, ixgbe_dev_start, why we need to disable it > again?