From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 7E2E66CC5 for ; Tue, 8 May 2018 15:30:15 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 May 2018 06:30:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,378,1520924400"; d="scan'208";a="197680601" Received: from pgsmsx107.gar.corp.intel.com ([10.221.44.105]) by orsmga004.jf.intel.com with ESMTP; 08 May 2018 06:30:13 -0700 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.194]) by PGSMSX107.gar.corp.intel.com ([169.254.7.161]) with mapi id 14.03.0319.002; Tue, 8 May 2018 21:30:12 +0800 From: "Dai, Wei" To: "Lu, Wenzhuo" , "Wu, Jingjing" , "Yigit, Ferruh" CC: "dev@dpdk.org" Thread-Topic: [PATCH v7 0/2] app/testpmd: add new commands to test new Tx/Rx offloads Thread-Index: AQHTyynnSVV0FASC1UeuHPYrzN/ELaQmAoWg Date: Tue, 8 May 2018 13:30:10 +0000 Message-ID: <49759EB36A64CF4892C1AFEC9231E8D66CF7EFE6@PGSMSX111.gar.corp.intel.com> References: <20180322080025.30830-1-wei.dai@intel.com> <20180403085735.3090-1-wei.dai@intel.com> In-Reply-To: <20180403085735.3090-1-wei.dai@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWIwNDJmZmEtZjIwYi00NGI4LTkyOWUtMWExNDEzZjhhMTQ2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkRPczBOT0ZZZXQxUkc3YUdESVFiUE9nOU9mV3VqK2pLK1ptTXpaY253TkU9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 0/2] app/testpmd: add new commands to test new Tx/Rx offloads X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 May 2018 13:30:16 -0000 Hi, Ferruh Thanks for your feedback. I lost your mail but I can found it in http://dpdk.org/ml/archives/dev/2018= -April/096900.html I will update new version of this patch for new offload API in my v8 big pa= tch for ethdev: check offloads. As my command to get offload capablites and configuration return all result= s on port level and all queues, I'd like to adopt your suggestion to use 'show port ...' I search '.help_str' in app/test-pmd/cmdline.c and find all existed 'port c= onfig ...' is for port level configuration. So if it is used to add new commands to enable/disable per-queue offloading= , the style will be broken. I'd like to use 'port config on|off ' to enable/disable= offloading on all queues. I also would like to use 'port rxq|txq on|of= f' to enable/disable offloading on a queue. All above my plan want to keep the style of current command and avoid to in= troduce more commands. Can you agree it ? Thanks & Best Regards -Wei > -----Original Message----- > From: Dai, Wei > Sent: Tuesday, April 3, 2018 4:58 PM > To: Lu, Wenzhuo ; Wu, Jingjing > > Cc: dev@dpdk.org; Dai, Wei > Subject: [PATCH v7 0/2] app/testpmd: add new commands to test new Tx/Rx > offloads >=20 > Existed testpmd commands can't support per queue offload configuration. > And there are different commands to enable or disable different offloadin= g. > This patch set add following commands to support new Tx/Rx offloading API > test. >=20 > To get Rx offload capability of a port, please run: > testpmd > rx_offload get capability >=20 > To get current Rx offload per queue and per port configuration of a port, > run: > tesstpmd > rx_offload get configuration >=20 > To enable or disable a Rx per port offloading, please run: > testpmd > rx_offload enable|disable per_port vlan_strip|ipv4_cksum|... > > This command will set|clear the associated bit in > dev->dev_conf.rxmode.offloads > for rte_eth_dev_configure and tx_conf->offloads of all Rx queues for > rte_eth_rx_queue_setup( ). >=20 > To enable or disable a Tx per port offloading, please run: > testpmd > rx_offload enable|disable per_queue vlan_strip|ipv4_cksum|... > >=20 > Same commands like "tx_offload ..." are also added to support new Tx > offload API test. >=20 > Signed-off-by: Wei Dai > Acked-by: Jingjing Wu >=20 > --- > v7: > update testpmd document > v6: > reconfig port and queues if offloading is enabled or disabled > v5: > don't depend on enum types defined in rte_ethdev. > v4: > improve testpmd command per port offload to set or clear the port > configuration > and the queue configuration of all queues. > v3: > add enum rte_eth_rx_offload_type and enum rte_eth_tx_offload_type > free memory of port->rx_offloads and port->tx_offloads when testpmd > is existed > v2: > use rte_eth_dev_rx_offload_name() and > rte_eth_dev_tx_offload_name(). > remove static const strings of Rx/Tx offload names. >=20 >=20 > Wei Dai (2): > app/testpmd: add commands to test new Rx offload API > app/testpmd: add commands to test new Tx offload API >=20 > app/test-pmd/cmdline.c | 759 > ++++++++++++++++++++++++++++ > app/test-pmd/testpmd.c | 34 +- > app/test-pmd/testpmd.h | 2 + > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 87 ++++ > 4 files changed, 878 insertions(+), 4 deletions(-) >=20 > -- > 2.9.5