From: "Dai, Wei" <wei.dai@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Wu, Yanglong" <yanglong.wu@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix VLAN strip setting fail for per port
Date: Fri, 18 May 2018 11:06:42 +0000 [thread overview]
Message-ID: <49759EB36A64CF4892C1AFEC9231E8D66CF833FC@PGSMSX111.gar.corp.intel.com> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E70611531B46A1@SHSMSX103.ccr.corp.intel.com>
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Friday, May 18, 2018 3:46 PM
> To: Wu, Yanglong <yanglong.wu@intel.com>; dev@dpdk.org
> Cc: Dai, Wei <wei.dai@intel.com>
> Subject: RE: [PATCH v2] net/ixgbe: fix VLAN strip setting fail for per port
>
> > -----Original Message-----
> > From: Wu, Yanglong
> > Sent: Friday, May 18, 2018 3:24 PM
> > To: dev@dpdk.org
> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Dai, Wei <wei.dai@intel.com>;
> > Wu, Yanglong <yanglong.wu@intel.com>
> > Subject: [PATCH v2] net/ixgbe: fix VLAN strip setting fail for per
> > port
> >
> > rxq->offload should synchronize with dev_conf
> >
> > Fixes: 860a94d3c692 ("net/ixgbe: support VLAN strip per queue
> > offloading in
> > VF")
> > Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
The release date is coming soon.
Sorry, I have to NACK it.
VLAN strip is per-queue feature,
If it is disabled on port level, it still can be enabled on queue level.
So the else branches still should be removed.
next prev parent reply other threads:[~2018-05-18 11:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 5:52 [dpdk-dev] [PATCH] " Yanglong Wu
2018-05-17 15:49 ` Zhang, Qi Z
2018-05-18 7:16 ` [dpdk-dev] [DPDK] " Yanglong Wu
2018-05-18 7:23 ` [dpdk-dev] [PATCH v2] " Yanglong Wu
2018-05-18 7:45 ` Zhang, Qi Z
2018-05-18 11:06 ` Dai, Wei [this message]
2018-05-18 12:36 ` Zhang, Qi Z
2018-05-18 14:08 ` Ferruh Yigit
2018-05-18 15:05 ` Dai, Wei
2018-05-18 16:10 ` Dai, Wei
2018-05-18 15:43 ` [dpdk-dev] [PATCH v3] net/ixgbe: config VLAN strip on the fly Wei Dai
2018-05-18 16:08 ` [dpdk-dev] [PATCH v4] " Wei Dai
2018-05-19 0:19 ` Zhang, Qi Z
2018-05-19 10:32 ` Dai, Wei
2018-05-19 10:11 ` [dpdk-dev] [PATCH v5] net/ixgbe: fix to " Wei Dai
2018-05-21 1:15 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49759EB36A64CF4892C1AFEC9231E8D66CF833FC@PGSMSX111.gar.corp.intel.com \
--to=wei.dai@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=yanglong.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).