From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 902BC2583 for ; Fri, 18 May 2018 13:08:03 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 May 2018 04:08:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,414,1520924400"; d="scan'208";a="59718632" Received: from pgsmsx102.gar.corp.intel.com ([10.221.44.80]) by orsmga002.jf.intel.com with ESMTP; 18 May 2018 04:08:01 -0700 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.194]) by PGSMSX102.gar.corp.intel.com ([169.254.6.245]) with mapi id 14.03.0319.002; Fri, 18 May 2018 19:06:43 +0800 From: "Dai, Wei" To: "Zhang, Qi Z" , "Wu, Yanglong" , "dev@dpdk.org" Thread-Topic: [PATCH v2] net/ixgbe: fix VLAN strip setting fail for per port Thread-Index: AQHT7no15G6H+aMKiEaVz3zyrhKo9qQ0lWuAgAC926A= Date: Fri, 18 May 2018 11:06:42 +0000 Message-ID: <49759EB36A64CF4892C1AFEC9231E8D66CF833FC@PGSMSX111.gar.corp.intel.com> References: <20180517055205.58766-1-yanglong.wu@intel.com> <20180518072341.27051-1-yanglong.wu@intel.com> <039ED4275CED7440929022BC67E70611531B46A1@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E70611531B46A1@SHSMSX103.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmM0NWVkZDgtOTFiNy00ODY5LTg1MGEtYzU4NTJhYzZkMzI0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoib3NENms3YXhkSUxcL0g2Sm1aWTlZbUMzNm16M09uY1NrbDZtb1VQNzJBNFdRUWlMdXdRaTFtTFwvSFN6cStKXC9QdyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix VLAN strip setting fail for per port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 May 2018 11:08:04 -0000 > -----Original Message----- > From: Zhang, Qi Z > Sent: Friday, May 18, 2018 3:46 PM > To: Wu, Yanglong ; dev@dpdk.org > Cc: Dai, Wei > Subject: RE: [PATCH v2] net/ixgbe: fix VLAN strip setting fail for per po= rt >=20 > > -----Original Message----- > > From: Wu, Yanglong > > Sent: Friday, May 18, 2018 3:24 PM > > To: dev@dpdk.org > > Cc: Zhang, Qi Z ; Dai, Wei ; > > Wu, Yanglong > > Subject: [PATCH v2] net/ixgbe: fix VLAN strip setting fail for per > > port > > > > rxq->offload should synchronize with dev_conf > > > > Fixes: 860a94d3c692 ("net/ixgbe: support VLAN strip per queue > > offloading in > > VF") > > Signed-off-by: Yanglong Wu >=20 > Acked-by: Qi Zhang The release date is coming soon. Sorry, I have to NACK it. VLAN strip is per-queue feature, If it is disabled on port level, it still can be enabled on queue level. So the else branches still should be removed.