From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 105522E41 for ; Sat, 19 May 2018 12:32:33 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 May 2018 03:32:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,417,1520924400"; d="scan'208";a="56664495" Received: from pgsmsx103.gar.corp.intel.com ([10.221.44.82]) by fmsmga001.fm.intel.com with ESMTP; 19 May 2018 03:32:31 -0700 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.194]) by PGSMSX103.gar.corp.intel.com ([169.254.2.118]) with mapi id 14.03.0319.002; Sat, 19 May 2018 18:32:30 +0800 From: "Dai, Wei" To: "Zhang, Qi Z" , "Lu, Wenzhuo" , "Ananyev, Konstantin" , "Wu, Yanglong" , "Yigit, Ferruh" CC: "dev@dpdk.org" Thread-Topic: [PATCH v4] net/ixgbe: config VLAN strip on the fly Thread-Index: AQHT7sU90cJvGAzz2EiZyIQgqQuTSKQ1qlKAgAExUCA= Date: Sat, 19 May 2018 10:32:29 +0000 Message-ID: <49759EB36A64CF4892C1AFEC9231E8D66CF8372C@PGSMSX111.gar.corp.intel.com> References: <1526658192-23106-1-git-send-email-wei.dai@intel.com> <1526659710-24420-1-git-send-email-wei.dai@intel.com> <039ED4275CED7440929022BC67E70611531B4AEF@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E70611531B4AEF@SHSMSX103.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzAxZDI5NGYtNWRkOC00NWM5LWJkZDYtNGI0ZDY3MDMzMTk1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSlV5YmhHSGFucVFZa3VLQzBXbGYxS0t6aTFcL0tPZGdcLzI3VGlsRENUZVE2SUhESWNwc3VyaFlcL2l1ZTRpR0tsNiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] net/ixgbe: config VLAN strip on the fly X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 May 2018 10:32:34 -0000 Hi, Zhang Qi Thanks for your feedback. I've just submitted v5 patch to follow your guidance. > -----Original Message----- > From: Zhang, Qi Z > Sent: Saturday, May 19, 2018 8:19 AM > To: Dai, Wei ; Lu, Wenzhuo ; > Ananyev, Konstantin ; Wu, Yanglong > ; Yigit, Ferruh > Cc: dev@dpdk.org > Subject: RE: [PATCH v4] net/ixgbe: config VLAN strip on the fly >=20 >=20 >=20 > > -----Original Message----- > > From: Dai, Wei > > Sent: Saturday, May 19, 2018 12:09 AM > > To: Lu, Wenzhuo ; Ananyev, Konstantin > > ; Zhang, Qi Z ; > > Wu, Yanglong ; Yigit, Ferruh > > > > Cc: dev@dpdk.org; Dai, Wei > > Subject: [PATCH v4] net/ixgbe: config VLAN strip on the fly > > > > The old ixgbe_vlan_offload_set() is called by > > rte_eth_dev_set_vlan_offload() which is meant to config VLAN > > strip/filter/extend on all queues. > > This old function is also called by > > rte_eth_dev_start()/ixgbe_dev_start() >=20 > OK, I think this is what we missed in previous patch, good capture, thank= s! >=20 > > which need support per-queue VALN strip on only parts of queues. > > So add new function ixgbe_vlan_offload_config() =3D old > > ixgbe_vlan_offload_set(). > > New ixgbe_vlan_offload_set =3D codes to align VLAN strip flags on all > > queues with port level setting + ixgbe_vlan_offload_configure(). > > > > Signed-off-by: Wei Dai > > Signed-off-by: Yanglong Wu >=20 > Though the code can be improved to remove some redundant , but I think > it's not a big deal right now. > BTW, I think we still need the fixed line, so it will be added during app= ly. >=20 > Fixes: 860a94d3c692 ("net/ixgbe: support VLAN strip per queue offloading = in > VF") >=20 > Acked-by: Qi Zhang