From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id E650F1B55E; Fri, 3 Aug 2018 14:57:56 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Aug 2018 05:57:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,438,1526367600"; d="scan'208";a="251463108" Received: from kmsmsx154.gar.corp.intel.com ([172.21.73.14]) by fmsmga006.fm.intel.com with ESMTP; 03 Aug 2018 05:53:40 -0700 Received: from pgsmsx112.gar.corp.intel.com ([169.254.3.172]) by KMSMSX154.gar.corp.intel.com ([169.254.12.236]) with mapi id 14.03.0319.002; Fri, 3 Aug 2018 20:53:39 +0800 From: "Dai, Wei" To: "Iremonger, Bernard" , "Wu, Jingjing" , "Lu, Wenzhuo" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: fix commands to config some offload Thread-Index: AQHUIwPPNLK42XfLB02NA4VcDkWFX6SrNRMAgACAY4CAAlYdsA== Date: Fri, 3 Aug 2018 12:53:38 +0000 Message-ID: <49759EB36A64CF4892C1AFEC9231E8D66D0668A6@PGSMSX112.gar.corp.intel.com> References: <1532403909-62194-1-git-send-email-wei.dai@intel.com> <1533173520-6623-1-git-send-email-wei.dai@intel.com> <8CEF83825BEC744B83065625E567D7C260CD2665@IRSMSX107.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260CD2665@IRSMSX107.ger.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDJiN2Q3MWYtNjNjYS00NDM0LWI3NGEtYWZiNjVjZDEzYmY5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUlE2TVljXC9OenF4VndNbDNPUkZWUnBjcEYycjNxVXVYOGpTa0laSWFZTVJmU0NhbFwvT0lrZ2FoR1pFNW93YlNpIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix commands to config some offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Aug 2018 12:57:57 -0000 Thanks, Iremonger. I will reply this patch with a v3 patch. > -----Original Message----- > From: Iremonger, Bernard > Sent: Thursday, August 2, 2018 5:12 PM > To: Dai, Wei ; Wu, Jingjing ; L= u, > Wenzhuo > Cc: dev@dpdk.org; Dai, Wei ; stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: fix commands to config some > offload >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Dai > > Sent: Thursday, August 2, 2018 2:32 AM > > To: Wu, Jingjing ; Lu, Wenzhuo > > > > Cc: dev@dpdk.org; Dai, Wei ; stable@dpdk.org > > Subject: [dpdk-dev] [PATCH] app/testpmd: fix commands to config some > > offload > > > > Without this patch, testpmd command to config Rx offload keep_crc > > would fail and report "Bad argument". > > This patch aslo fix the command to config the Tx offload mbuf_fast_free= . > > > > Fixes: 70815c9ecadd ("ethdev: add new offload flag to keep CRC") > > Fixes: c73a9071877a ("app/testpmd: add commands to test new offload > > API") > > Cc: stable@dpdk.org > > > > Signed-off-by: Wei Dai > > Tested-by: Yuan Peng >=20 > Should have been [PATCH v2] otherwise fine. >=20 > Acked-by: Bernard Iremonger >=20