From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7949CA00C3; Fri, 14 Jan 2022 17:44:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3472142782; Fri, 14 Jan 2022 17:44:06 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 1C5FA4277A for ; Fri, 14 Jan 2022 17:44:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642178645; x=1673714645; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=vlYDhrwfRB8SpuIwg6rrccp7GTL2DkDPErHESWxijHY=; b=RlEeBCJzA05JeqZLJC44IhIegLPeekb9OeFskP0tW8wQoEPxnfZDGCS0 Xw3s1GW/hU619/tiy8je7ANMCW28fA+QU9IgqvBa31Z5LiuO9Q23zaPMr JSFBm3pwE+Zxaca0QZaTTxthR3H/4IjgASzDl4K+dXIVUaVuPoaNsIcdA ueCUgNGeugkiduNfm8bz/mi/pu24u/Kb+KJn7qhrWjkwSDtXrUT9KdROE d5QATxvDgntMJPjzOH/Y/HcLIR2o11EeQFOAnugOdZFC01fMGVlTe801b 0JXkK5PJxlXHYVT8SOwMJv9SzS+B9ySGTzW0WWT0ztWhJ849BN5Nh6GBp w==; X-IronPort-AV: E=McAfee;i="6200,9189,10226"; a="241843079" X-IronPort-AV: E=Sophos;i="5.88,289,1635231600"; d="scan'208";a="241843079" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2022 08:44:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,289,1635231600"; d="scan'208";a="621053582" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga002.fm.intel.com with ESMTP; 14 Jan 2022 08:44:01 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 14 Jan 2022 08:44:00 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 14 Jan 2022 08:44:00 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 14 Jan 2022 08:44:00 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IHaqaHC68XCfZu8Ta7n9WDYoRWkUzxQUyXhSTXWywG1SGKlg4fmGvwpzbGw1kqrO1b9sdFKWCiyLhJmfAeRYd65uO5uFIE/gcumLpPQl4foBqk9caiMyiR0UTEXXFE7ZXNhy/kMgyWQK90ol4jofsvGfZQiLbjWj8PymJkAxhQ/D3Vt5/wyN3oMT7+jr89t+jdiScLzhOjHKF/NSuOboOvjXgTgA0Yc6Oqy4e+Xso6VbWRwnAdv+/lrxdkoypAfB00PNvfOUk0U3gqnoG6EegwBZimXKN8ZN3eTakN0dJ6FslKFhVprwhsNYIR5ERb4eLYpS/XGup1l+FnmC3MrtOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QxIKELD2791mmFylgFOZiFmPUCyTP4vLukioqwGrkOQ=; b=ev09qZZteJrPaOYo/lQiK78Yl3f2tIyvavV7hsX+FFBBgO0aSDCxT4Udo+NxOYVB1qdoCyEXUBaxD/w9EDtjovHAC5UXf18ar0iYzJopUpc+qLu4LmkLRHFy0tAYxvzOEzTFWYUvemM7lZQ14bvWlNMR6ZDP2a3xANmJUmnrKlVtp5fcT9aUzCADiNb6USeIFWuHudscZpTsKk5yuHKXUihU1EiMvBkRx9lYMmJSb+BEpOU+tCCU2+tdZn5fPdK/y8hHbn7nym0ZZ8ZIJDeHzkvOMajbOy+zS4iteterwFqOP63wytddlOhIZnQFROhGyBf9bdraYVf0pwm/4rlMGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5783.namprd11.prod.outlook.com (2603:10b6:510:128::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.9; Fri, 14 Jan 2022 16:44:00 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4888.012; Fri, 14 Jan 2022 16:43:59 +0000 Message-ID: <49900a8c-f9d1-f69f-04f8-b49a4aeebd5e@intel.com> Date: Fri, 14 Jan 2022 16:43:53 +0000 Content-Language: en-US To: Stephen Hemminger , Tudor Cornea CC: , , , References: <1637781854-74761-1-git-send-email-tudor.cornea@gmail.com> <1642173499-59396-1-git-send-email-tudor.cornea@gmail.com> <20220114082415.69752802@hermes.local> From: Ferruh Yigit Subject: Re: [PATCH v5] kni: allow configuring the kni thread granularity X-User: ferruhy In-Reply-To: <20220114082415.69752802@hermes.local> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0086.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::26) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 793367f7-6717-4e5d-05c5-08d9d77d106b X-MS-TrafficTypeDiagnostic: PH0PR11MB5783:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qrMxhxbehMIuU0CGKnZOEy5aJSlOGm+jY9JMbo4OmuwmDRcXLm9D+pL/62OzIDB6rWfnnTkHx+lJBJIm0tYKE4WRg54F2KvFy+e/HIY5uVHLVrVSBKFeH6sjBf9mK12UAePBpk/RxBOIoooUvLIPrYRtM95ke0s2XPP1cxeE6lWP8HtCQxL/hGzKoo78sHaHGFiTtKGqSqd42sWyqA0NO88dX9lVKFPi/DjtyD+HqoQWXkXxdoqB0taE84IdynOOfows0Y9KlCSl8OvB40PuH/QiYd1RVsxd3oONGQEIshcXEwk+4C7+6p5AE7UlATN9KMzaff4ocBLqbHdFd0G+YiUuu4njzBwRUCsoLIXTVYKQUe8oMd/p82Q9YI5jKkMebnKrO2qOjHJCQrf2txcyDFpIm+9gDcWAAI2gmd7WNaS/c8w+mb21N+X+JxStTWwNaspmRhcNUAsAvW0lcwdZFtmeGlY0RxMSCzCyE0+mwx0KDOryP/ULiwm8wpI2T3WOVMgOw+Fd5m/Chtye2m+L1rMldmKyDdIqRnAFLjzW/Pe01TW7WMmgsGLe+8+AFl5jBiJoqjqpeLgGELC0ZSRD++l1iiBjkOIq+l29O15lhEYLgBhgDzjZA4U5FzXtK83C/+Bt9lq6Lbxw/ulDEQ5XHmL2A6NdNmS1Tc0bMKClmlwErPjirBK4tD4fcyIiUEw1VYI75fZXaybDN6HmutyM8w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(2906002)(66476007)(110136005)(2616005)(6486002)(4326008)(53546011)(5660300002)(36756003)(508600001)(86362001)(66556008)(8936002)(316002)(8676002)(186003)(6512007)(26005)(38100700002)(83380400001)(31696002)(31686004)(66946007)(82960400001)(44832011)(6666004)(6506007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a1l3SUxTeS9KVlIrY2Z4VDliRlAxYmhmdExrTE5FZytSMm4rdk9oVktyNjds?= =?utf-8?B?SDArdTQ2UjFscXY3cnNyZ3Y2NnY0R24wYWRaalZZWm5pT2E5UmIyNmRhbE9R?= =?utf-8?B?YVJycWU1RmdIdEVJdkpwUUFjcWo3UlNkaERjOWZsQkIxdStiMU9SRXBtSGwv?= =?utf-8?B?djRLZ2tuVnZFL3Fta21KL3RNZytVQWVGUlREL05LREJ4UE5OYllnK0JCcW1R?= =?utf-8?B?bzNNTmFCTFcrb0c4TUpQZjlXbjR6a25wYnY3T25peDJvelYrUTlBS1FDOVlv?= =?utf-8?B?Y1YyOGJtQkkrTE5wOGJROWIxMnp2RXJvYjl5cUcyei9BTXVIVEdWYXB3VW1i?= =?utf-8?B?ZzJJczRwK1ovaStnMkZEQmwvRkU5TXpjY2N2YTJIRHJnc2UwOUZCNk4rZ2dC?= =?utf-8?B?OHdycGNzU1pmV21sdWovQ1dLQzZrMVI5M0MxSzQrN2FmUGk2SDZkNjYvNDdK?= =?utf-8?B?QnlqWS93UTZPczlsWFYrcEd3cmM1WVlKK0EyLzRyNmE1cGJLUTd1d3U3eFVQ?= =?utf-8?B?WlhFYklZVjIyeWR3elBtMGwwOW5EOFJMNVFmdWNIL1krYkhZTnBQUmtPek1I?= =?utf-8?B?SUsyM0c1RzVSbis4V1B6RkZmQXpDekdYcVBPTkZlMnd6OTl1dUVsQUF2aWVH?= =?utf-8?B?YWJXUnZoVHpEU0R2Ukl3bzZCK096Sjhtb0F5dlRLZUcxbmxyeTVwZExabklH?= =?utf-8?B?a0E3Z1RaR2pCN3BZWUorNTdWZExrR3NoV0wxK2o3M2RJVkdSelhOMTQyd1Jv?= =?utf-8?B?L01CV3htU1JPeDhRUE9FZDJINlh0YWF4dGNzay9KRmZ3MHFzNTVjM0xtd0tp?= =?utf-8?B?K2VxSytHbE9MRTdVUnF0SnVJaVpDU2YzUFgzY3JTdXVFb2RvSHMreENmYmpr?= =?utf-8?B?Q3JRZEpYTDVHa2Rid04xNmx3YzNhekdPS0haR3p2YW1HUGVrVFZMWDNHS2Nl?= =?utf-8?B?WFIyaGZ1Ly9RN3pIMk9yQkZiT0RVSmFEekRZRHF0Q1lPNmxJZUswRzZYRFVQ?= =?utf-8?B?OStqZ05mVk1hSGpVUVlDQkN0K2J0QU1pWmdtSmFwNzlKWnpkTHUxblV0MHdT?= =?utf-8?B?cTFrcXQyVUZNVGJGL0VMUDY0bURYZFljaHE2SEZhWWdUNHllbVJ6dmlpUkUx?= =?utf-8?B?SkxmWE9nTWs3QzI4SkJvRWRIS2QzbVlxc1FCU1RYNHZQOGVJaHFiRnB6TUhv?= =?utf-8?B?MWhWcWtjS2NtUFBFdmVXOXlrRjRTNzUvdS9JM0ZuKy9vS3hab2kxblFyOXNh?= =?utf-8?B?UzNsQS9Ud3V5UmJweW9JRDJyRXZuQUpsdUdEOVBzdnAyOCtQenNnS05HNUhi?= =?utf-8?B?TXViY2NiOVVGaUJVcEtveE1aR1d1N2pXUFozbnBjSFhBcXNGZ3kzNXJSd0tR?= =?utf-8?B?ZFN6NnUwNDk3MlZ2RmhQVlRNTzB5MmpVSk9ZNmxEVFhGa1FuNzROVy9Sa2NQ?= =?utf-8?B?MEhEYllCaDkxbldrcDczNjl3SjEzL29vUk1ZSjdRQ2ZLajNadlEzbUZqZDE4?= =?utf-8?B?VXVYTG1LVzNPYzNaa3BrWTdGYmxVaExkYnhVMlRPRUdFMGJjR2d5V09FSytY?= =?utf-8?B?MGFIaGlyQmlBSEt5Mmdsd00zcEdWZUFSQklBNlNOUC80SzJybDdEbDVVcWk0?= =?utf-8?B?K25OOWtEUFI3UThaZW9zYUp1WUQzSUhCcWpJSXNybjhVNFhCT1dhSjFxL251?= =?utf-8?B?T2RqaVVHeDFQc1YyMDl0c1JtYWhnU1NYakJNQ3Q5ZlBFTjUyam9DbWVMNTJx?= =?utf-8?B?VzgzQ0NiRDFXanhONW5FTWp0dWY5WnppaGR2NkR2RVVCV215emIrUUhoT0Qx?= =?utf-8?B?Ukd3WXNSYU10TzE2V1ZJbHROREllTm1tSyt5Q1VOTDgwS1pIdGsvdUtGMDMw?= =?utf-8?B?eCt0MlJCaG1sNWwwMGxuVjBleEVwWEJsOEJCa0RqUFIzdFdFYlliOGgvbWph?= =?utf-8?B?WlBCVVFVdUFMYmpodi9meTBjMWl3VTc5c1lSMVh5K1pIN1Q0RWN2cnp1VXkr?= =?utf-8?B?WWVDRmo0bURsbVFsSjRyeEVvUURGSEdqNFpJK1JsQkF2MHF5NFI0ZU5VdkEx?= =?utf-8?B?WXJ4OHRFZlpOU2xGZXpudVAxV09WR0ovc1orT2szVU1HTjJLNHRjRFdpaXRW?= =?utf-8?B?WVF6cHdIMi9rV1Y0cTkrNmdYY2VZV2VzOU1pU3VwRFZ4OGpZSHUxZ1VMUXR3?= =?utf-8?Q?BN4F6PjIyLXpAcIesdOog1Q=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 793367f7-6717-4e5d-05c5-08d9d77d106b X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2022 16:43:59.8939 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: l4bipoxBbXYPqQGaCToRf9SruzYgHIiRn1li9aAhYFpvSWNOogky90p5OV4x/n+S87QLioM/fGPMp5dPkged4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5783 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/14/2022 4:24 PM, Stephen Hemminger wrote: > On Fri, 14 Jan 2022 17:18:19 +0200 > Tudor Cornea wrote: > >> +module_param(min_scheduling_interval, long, 0644); >> +MODULE_PARM_DESC(min_scheduling_interval, >> +"\t\tKni thread min scheduling interval (default=100 microseconds):\n" >> +"\t\t" >> +); >> + >> +module_param(max_scheduling_interval, long, 0644); >> +MODULE_PARM_DESC(max_scheduling_interval, >> +"\t\tKni thread max scheduling interval (default=200 microseconds):\n" >> +"\t\t" >> +); > > Please don't add more bad module parameter strings. > The KNI author did something no other kernel modules do with tabs > and double spacing, stop this bogus stuff. > The patch is good, let's not block it for the module parameter string, all can be fixed with another patch. Can you please give a sample what is a common way of it, me or Tudor can do the patch? > Is there any reason you have to use KNI at all. > KNI is broken on many levels and is not fixable. > What about virtio or tap?