From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f172.google.com (mail-we0-f172.google.com [74.125.82.172]) by dpdk.org (Postfix) with ESMTP id 2A8F7AFD5 for ; Fri, 18 Apr 2014 15:29:03 +0200 (CEST) Received: by mail-we0-f172.google.com with SMTP id t61so1589055wes.31 for ; Fri, 18 Apr 2014 06:29:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=aPp5eYOF1kKp6UZh1KKq4Ly+0qBtsOopzcaqQVPMUAY=; b=hKMQOhMKxtOaZGpyjwQNKUXBQudFsa15F1wSKSOGlbuLaQL+GuYoP3mXPpcY4xreDK OV0K8knmIHKugNGr5P/LPufdEGmr3cZHET1S71rPoCG3ckW9tY1m8/Eeorjnxi7CF2AK uOYwuI8bQzCutjc34qokavzxZN/HbQSYHleENGLnYb7C0SXvAWkkjPHT/fgcNO9dtbdc a2g/t1SM4fbc5FBvoQ4FJcS+IQLTQmGUgbjsDBtDMKkXgU96m3hPN+Y6sVCUpLOQWEOV Nw2fcXnmQRdsW0aWCIgezsJbhkC9hG0kJ9pQQV1VesNG96jLuBase1X3UTqMsat9F/7z pJ/Q== X-Gm-Message-State: ALoCoQmfQZKrZFsG8Kn1TOSxinJjR2yhfAW07wl0qwiHuVBC5BzjlfCZUmvrOL34UVuxDSVO88M3 X-Received: by 10.180.24.72 with SMTP id s8mr2477317wif.20.1397827743992; Fri, 18 Apr 2014 06:29:03 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id ez5sm43616214wjd.9.2014.04.18.06.29.02 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Apr 2014 06:29:03 -0700 (PDT) From: Thomas Monjalon To: Neil Horman Date: Fri, 18 Apr 2014 15:29:01 +0200 Message-ID: <49923176.Wq7YvMNVY1@xps13> Organization: 6WIND User-Agent: KMail/4.12.4 (Linux/3.14.1-1-ARCH; KDE/4.12.4; x86_64; ; ) In-Reply-To: <20140418131849.GC4053@localhost.localdomain> References: <1397585169-14537-2-git-send-email-nhorman@tuxdriver.com> <465940823.XQ0HDUOTVm@xps13> <20140418131849.GC4053@localhost.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 01/15 v2] makefiles: Fixed -share command line option error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Apr 2014 13:29:03 -0000 2014-04-18 09:18, Neil Horman: > On Fri, Apr 18, 2014 at 01:23:19PM +0200, Thomas Monjalon wrote: > > I think that CPU_LDFLAGS should be prefixed with -Wl, in case of CC > > linking. So blindly assigning CC to LD variable seems a bad idea. > > Other makefiles have different O_TO_S commands depending of LINK_USING_CC. > > I'm not so sure about that. Or more specifically, I wonder if some more > rework isn't needed here. I say that because, while what you say makes > sense in terms of formatting the CPU_FLAGS variable for use with CC, the > only current use of CPU_LDFLAGS set -melf_i386, which IIRC is a gcc flag, > not meant to be passed to LD. I can change the makefile to completely > rewrite the comand based on LINK_USING_CC, but it seems to me that > CPU_LDFLAGS should not be passed in the use of the LD case. Right, -melf_i386 shouldn't be a LDFLAG. Feel free to fix it. By the way, It's cleaner to prepare -Wl prefixing and keep an empty LDFLAGS. -- Thomas