From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Raslan Darawsheh <rasland@mellanox.com>
Cc: dev@dpdk.org, "keith.wiles@intel.com" <keith.wiles@intel.com>,
Shahaf Shuler <shahafs@mellanox.com>,
Ori Kam <orika@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v4 2/2] net/tap: add queues when attaching from secondary process
Date: Wed, 3 Oct 2018 17:31:03 +0100 [thread overview]
Message-ID: <499593ee-22cf-7f2d-f004-a4486468b87c@intel.com> (raw)
In-Reply-To: <1910504.ryvcqbe86A@xps>
On 10/2/2018 11:43 AM, Thomas Monjalon wrote:
> 02/10/2018 12:34, Raslan Darawsheh:
>> --- a/doc/guides/rel_notes/release_18_11.rst
>> +++ b/doc/guides/rel_notes/release_18_11.rst
>> @@ -67,6 +67,10 @@ New Features
>> SR-IOV option in Hyper-V and Azure. This is an alternative to the previous
>> vdev_netvsc, tap, and failsafe drivers combination.
>>
>> +* **Added TAP Rx/Tx queues sharing with a secondary process.**
>> +
>> + A secondary process can attach a TAP device created in the primary process,
>> + probe the queues, and process Rx/Tx in a secondary process.
>
> A blank line is missing here.
>
>> @@ -2006,9 +2115,23 @@ rte_pmd_tap_probe(struct rte_vdev_device *dev)
>> TAP_LOG(ERR, "Failed to probe %s", name);
>> return -1;
>> }
>> - /* TODO: request info from primary to set up Rx and Tx */
>> eth_dev->dev_ops = &ops;
>> eth_dev->device = &dev->device;
>> + eth_dev->rx_pkt_burst = pmd_rx_burst;
>> + eth_dev->tx_pkt_burst = pmd_tx_burst;
>> + if (!rte_eal_primary_proc_alive(NULL)) {
>> + TAP_LOG(ERR, "Primary process is missing");
>> + return -1;
>> + }
>> + process_private = (struct pmd_process_private *)
>> + rte_zmalloc_socket(name,
>> + sizeof(struct pmd_process_private),
>> + RTE_CACHE_LINE_SIZE,
>> + eth_dev->device->numa_node);
>> +
>> + ret = tap_mp_attach_queues(name, eth_dev);
>> + if (ret != 0)
>> + return -1;
>> rte_eth_dev_probing_finish(eth_dev);
>> return 0;
>> }
>
> Should we manage rte_pmd_tun_probe too?
I was about to ask same one, they share dev_ops, so tun also should be
supporting multiple queue, if so why not update it?
next prev parent reply other threads:[~2018-10-03 16:31 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 12:29 [dpdk-dev] [RFC] " Raslan Darawsheh
2018-06-07 19:09 ` Wiles, Keith
2018-06-07 23:24 ` Raslan Darawsheh
2018-06-08 2:52 ` Wiles, Keith
2018-06-12 12:46 ` Wiles, Keith
2018-06-12 13:21 ` Raslan Darawsheh
2018-07-20 10:57 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2018-09-27 11:19 ` [dpdk-dev] [PATCH v3 1/2] net/tap: change queue fd to be pointers to process private Raslan Darawsheh
2018-09-27 11:19 ` [dpdk-dev] [PATCH v3 2/2] net/tap: add queues when attaching from secondary process Raslan Darawsheh
2018-09-27 13:04 ` Wiles, Keith
2018-09-27 18:53 ` Thomas Monjalon
2018-10-02 10:34 ` [dpdk-dev] [PATCH v4 1/2] net/tap: change queue fd to be pointers to process private Raslan Darawsheh
2018-10-02 10:34 ` [dpdk-dev] [PATCH v4 2/2] net/tap: add queues when attaching from secondary process Raslan Darawsheh
2018-10-02 10:41 ` Thomas Monjalon
2018-10-02 10:50 ` Raslan Darawsheh
2018-10-02 11:38 ` Thomas Monjalon
2018-10-03 16:28 ` Ferruh Yigit
2018-10-02 10:43 ` Thomas Monjalon
2018-10-03 16:31 ` Ferruh Yigit [this message]
2018-10-03 18:00 ` Ferruh Yigit
2018-10-03 17:59 ` [dpdk-dev] [PATCH v4 1/2] net/tap: change queue fd to be pointers to process private Ferruh Yigit
2018-09-27 13:17 ` [dpdk-dev] [PATCH v3 " Wiles, Keith
2018-10-02 10:30 ` Raslan Darawsheh
2018-10-02 12:58 ` Wiles, Keith
2018-10-03 17:27 ` Ferruh Yigit
2018-07-20 11:15 ` [dpdk-dev] [PATCH v3] net/tap: add queues when attaching from secondary process Thomas Monjalon
2018-07-20 15:35 ` Wiles, Keith
2018-07-20 21:51 ` Thomas Monjalon
2018-07-21 13:44 ` Wiles, Keith
2018-08-23 11:51 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499593ee-22cf-7f2d-f004-a4486468b87c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=orika@mellanox.com \
--cc=rasland@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).