From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
by dpdk.org (Postfix) with ESMTP id EC7502C6E
for <dev@dpdk.org>; Thu, 13 Apr 2017 13:04:53 +0200 (CEST)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
13 Apr 2017 04:04:52 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.37,194,1488873600"; d="scan'208";a="88643147"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122])
([10.237.220.122])
by fmsmga006.fm.intel.com with ESMTP; 13 Apr 2017 04:04:52 -0700
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
Andriy Berestovskyy <Andriy.Berestovskyy@caviumnetworks.com>
Cc: Maciej Czekaj <maciej.czekaj@caviumnetworks.com>, dev@dpdk.org
References: <1490968669-9161-1-git-send-email-Andriy.Berestovskyy@caviumnetworks.com>
<20170403151315.2yrchyh4fgpjn3ha@localhost.localdomain>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <49a27795-e6b8-7510-beda-2eb4c533b874@intel.com>
Date: Thu, 13 Apr 2017 12:04:51 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
Thunderbird/52.0
MIME-Version: 1.0
In-Reply-To: <20170403151315.2yrchyh4fgpjn3ha@localhost.localdomain>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 1/2] net/thunderx: add empty link up/down
callbacks
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Apr 2017 11:04:54 -0000
On 4/3/2017 4:13 PM, Jerin Jacob wrote:
> On Fri, Mar 31, 2017 at 03:57:48PM +0200, Andriy Berestovskyy wrote:
>> Some applications and DPDK examples expect link up/down
>> functionality to be provided.
>>
>> Signed-off-by: Andriy Berestovskyy <Andriy.Berestovskyy@caviumnetworks.com>
>> ---
>> drivers/net/thunderx/nicvf_ethdev.c | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
>>
>> diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c
>> index 1060319..984c218 100644
>> --- a/drivers/net/thunderx/nicvf_ethdev.c
>> +++ b/drivers/net/thunderx/nicvf_ethdev.c
>> @@ -1924,11 +1924,25 @@ nicvf_dev_configure(struct rte_eth_dev *dev)
>> return 0;
>> }
>>
>> +static int
>> +nicvf_dev_set_link_up(struct rte_eth_dev *dev __rte_unused)
>> +{
>> + return 0;
>> +}
>> +
>> +static int
>> +nicvf_dev_set_link_down(struct rte_eth_dev *dev __rte_unused)
>> +{
>> + return 0;
>> +}
>
>
> Since the VF drivers can't really initiate link_up and link_down and
> other VF drivers like i40e VF is not setting this callback. I think, it is
> OK keep it as -ENOSUP(which is default).
>
> Since Christain Acked on the fix on the usage of examples/ip_pipeline
> application. Probably we are OK without this change.
Any update planned to this patch? Should I update this as nack?
>
> http://dpdk.org/ml/archives/dev/2017-March/062704.html
>
> Any thought from ethdev maintainers?
>
>> +
>> /* Initialize and register driver with DPDK Application */
>> static const struct eth_dev_ops nicvf_eth_dev_ops = {
>> .dev_configure = nicvf_dev_configure,
>> .dev_start = nicvf_dev_start,
>> .dev_stop = nicvf_dev_stop,
>> + .dev_set_link_up = nicvf_dev_set_link_up,
>> + .dev_set_link_down = nicvf_dev_set_link_down,
>> .link_update = nicvf_dev_link_update,
>> .dev_close = nicvf_dev_close,
>> .stats_get = nicvf_dev_stats_get,
>> --
>> 2.7.4
>>